Changeset 61457

Timestamp:

01/09/2026 04:26:02 AM (8 months ago)

Author:

westonruter

Message:

Code Modernization: Use null coalescing operator instead of isset() ternaries in remaining core files.

Developed as a subset of ​https://github.com/WordPress/wordpress-develop/pull/10654
Initially developed in ​https://github.com/WordPress/wordpress-develop/pull/4886

Follow-up to [61456], [61455], [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403].

Props costdev, westonruter, jrf, SergeyBiryukov, swissspidy, hellofromTonya, marybaum, oglekler, dmsnell, chaion07, noisysocks, mukesh27.
See #63430.
Fixes #58874.

Location:

trunk/src/wp-includes

Files:

• IXR/class-IXR-client.php (modified) (1 diff)
• class-wp-duotone.php (modified) (4 diffs)
• class-wp-hook.php (modified) (1 diff)
• class-wp-theme.php (modified) (3 diffs)
• deprecated.php (modified) (3 diffs)
• pluggable.php (modified) (1 diff)
• theme.php (modified) (2 diffs)

trunk/src/wp-includes/IXR/class-IXR-client.php

@@ -32 +32 @@
             $bits = parse_url($server);
             $this->server = $bits['host'];
-            $this->port = isset($bits['port']) ? $bits['port'] : 80;
-            $this->path = isset($bits['path']) ? $bits['path'] : '/';
+            $this->port = $bits['port'] ?? 80;
+            $this->path = $bits['path'] ?? '/';
 
             // Make absolutely sure we have a path

trunk/src/wp-includes/class-wp-duotone.php

@@ -210 +210 @@
                 );
 
-                $factor = isset( $angle_units[ $unit ] ) ? $angle_units[ $unit ] : 1;
+                $factor = $angle_units[ $unit ] ?? 1;
 
                 return (float) $value * $factor;
@@ -973 +973 @@
                  * treated as a selector and requires scoping.
                  */
-                $experimental_duotone = isset( $block_type->supports['color']['__experimentalDuotone'] )
-                        ? $block_type->supports['color']['__experimentalDuotone']
-                        : false;
+                $experimental_duotone = $block_type->supports['color']['__experimentalDuotone'] ?? false;
                 if ( $experimental_duotone ) {
                         $root_selector = wp_get_block_css_selector( $block_type );
@@ -1004 +1002 @@
                 // Get the per block settings from the theme.json.
                 $tree              = wp_get_global_settings();
-                $presets_by_origin = isset( $tree['color']['duotone'] ) ? $tree['color']['duotone'] : array();
+                $presets_by_origin = $tree['color']['duotone'] ?? array();
 
                 self::$global_styles_presets = array();
@@ -1305 +1303 @@
          */
         public static function migrate_experimental_duotone_support_flag( $settings, $metadata ) {
-                $duotone_support = isset( $metadata['supports']['color']['__experimentalDuotone'] )
-                        ? $metadata['supports']['color']['__experimentalDuotone']
-                        : null;
+                $duotone_support = $metadata['supports']['color']['__experimentalDuotone'] ?? null;
 
                 if ( ! isset( $settings['supports']['filter']['duotone'] ) && null !== $duotone_support ) {

trunk/src/wp-includes/class-wp-hook.php

@@ -493 +493 @@
         #[ReturnTypeWillChange]
         public function offsetGet( $offset ) {
-                return isset( $this->callbacks[ $offset ] ) ? $this->callbacks[ $offset ] : null;
+                return $this->callbacks[ $offset ] ?? null;
         }
 

trunk/src/wp-includes/class-wp-theme.php

@@ -516 +516 @@
                         }
                         // Set the parent. Pass the current instance so we can do the checks above and assess errors.
-                        $this->parent = new WP_Theme( $this->template, isset( $theme_root_template ) ? $theme_root_template : $this->theme_root, $this );
+                        $this->parent = new WP_Theme( $this->template, $theme_root_template ?? $this->theme_root, $this );
                 }
 
@@ -777 +777 @@
          */
         public function parent() {
-                return isset( $this->parent ) ? $this->parent : false;
+                return $this->parent ?? false;
         }
 
@@ -1398 +1398 @@
 
                 $post_templates = $this->get_post_templates();
-                $post_templates = isset( $post_templates[ $post_type ] ) ? $post_templates[ $post_type ] : array();
+                $post_templates = $post_templates[ $post_type ] ?? array();
 
                 /**

trunk/src/wp-includes/deprecated.php

@@ -4265 +4265 @@
         _deprecated_function( __FUNCTION__, '6.0.0', 'wp_should_skip_block_supports_serialization()' );
 
-        $border_support = isset( $block_type->supports['__experimentalBorder'] )
-                ? $block_type->supports['__experimentalBorder']
-                : false;
+        $border_support = $block_type->supports['__experimentalBorder'] ?? false;
 
         return is_array( $border_support ) &&
@@ -4289 +4287 @@
         _deprecated_function( __FUNCTION__, '6.0.0', 'wp_should_skip_block_supports_serialization()' );
 
-        $dimensions_support = isset( $block_type->supports['__experimentalDimensions'] )
-                ? $block_type->supports['__experimentalDimensions']
-                : false;
+        $dimensions_support = $block_type->supports['__experimentalDimensions'] ?? false;
 
         return is_array( $dimensions_support ) &&
@@ -4313 +4309 @@
         _deprecated_function( __FUNCTION__, '6.0.0', 'wp_should_skip_block_supports_serialization()' );
 
-        $spacing_support = isset( $block_type->supports['spacing'] )
-                ? $block_type->supports['spacing']
-                : false;
+        $spacing_support = $block_type->supports['spacing'] ?? false;
 
         return is_array( $spacing_support ) &&

trunk/src/wp-includes/pluggable.php

@@ -1723 +1723 @@
                  * @param string   $host  The host name of the redirect destination; empty string if not set.
                  */
-                $allowed_hosts = (array) apply_filters( 'allowed_redirect_hosts', array( $wpp['host'] ), isset( $lp['host'] ) ? $lp['host'] : '' );
+                $allowed_hosts = (array) apply_filters( 'allowed_redirect_hosts', array( $wpp['host'] ), $lp['host'] ?? '' );
 
                 if ( isset( $lp['host'] ) && ( ! in_array( $lp['host'], $allowed_hosts, true ) && strtolower( $wpp['host'] ) !== $lp['host'] ) ) {

trunk/src/wp-includes/theme.php

@@ -1105 +1105 @@
 function set_theme_mod( $name, $value ) {
         $mods      = get_theme_mods();
-        $old_value = isset( $mods[ $name ] ) ? $mods[ $name ] : false;
+        $old_value = $mods[ $name ] ?? false;
 
         /**
@@ -3429 +3429 @@
         }
 
-        return isset( $_wp_registered_theme_features[ $feature ] ) ? $_wp_registered_theme_features[ $feature ] : null;
+        return $_wp_registered_theme_features[ $feature ] ?? null;
 }