Changeset 61465 for trunk/src/wp-admin/includes/template.php

Timestamp:

01/10/2026 06:36:40 AM (4 months ago)

Author:

westonruter

Message:

Menus: Ensure a WP_Post instance gets passed to get_post_states() in wp_setup_nav_menu_item().

The get_post_states() function is also hardened to short-circuit in case a non-WP_Post is passed. A test is added to verify this.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10706

Follow-up to [47211].

Props apedog, josephscott, joemcgill, westonruter.
See #49374.
Fixes #58932.

File:

• trunk/src/wp-admin/includes/template.php (modified) (1 diff)

trunk/src/wp-admin/includes/template.php

@@ -2297 +2297 @@
 function get_post_states( $post ) {
     $post_states = array();
+    if ( ! $post instanceof WP_Post ) {
+        return $post_states;
+    }
+
     $post_status = $_REQUEST['post_status'] ?? '';