Context Navigation

includesTemplate.php

Timestamp:

01/10/2026 06:36:40 AM (6 months ago)

Author:

westonruter

Message:

Menus: Ensure a WP_Post instance gets passed to get_post_states() in wp_setup_nav_menu_item().

The get_post_states() function is also hardened to short-circuit in case a non-WP_Post is passed. A test is added to verify this.

Follow-up to [47211].

Props apedog, josephscott, joemcgill, westonruter.
See #49374.
Fixes #58932.

File:

-              r60253
+              r61465
                 remove_meta_box( 'dashboard2', 'dashboard', 'normal' );
+        }
+        /**
+         * Tests that get_post_states() handles a null value gracefully.
+         *
+         * This can happen when get_post() returns null (e.g., when a post
+         * doesn't exist) and that result is passed to get_post_states()
+         * without being checked first.
+         *
+         * @ticket 58932
+         *
+         * @covers ::get_post_states
+         */
+        public function test_get_post_states_with_null_returns_empty_array() {
+                $result = get_post_states( null );
+                $this->assertSame( array(), $result, 'get_post_states() should return an empty array when WP_Post is not supplied.' );
+        }
+}

Note: See TracChangeset for help on using the changeset viewer.