Changeset 61466 for trunk/tests/phpunit/tests/widgets/wpBlockThemeRegisterClassicSidebar.php

Timestamp:

01/10/2026 06:28:18 PM (9 months ago)

Author:

westonruter

Message:

Widgets: Ensure a widget is registered prior to checking its ID in is_active_widget().

This avoids a possible PHP warning due to an undefined array key.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10710

Follow-up to [11090], [7080].

Props sageth, josephscott, Ipstenu, mindctrl, westonruter.
See #8441, #6023.
Fixes #57518.

File:

• trunk/tests/phpunit/tests/widgets/wpBlockThemeRegisterClassicSidebar.php (modified) (2 diffs)

trunk/tests/phpunit/tests/widgets/wpBlockThemeRegisterClassicSidebar.php

@@ -33 +33 @@
                 global $wp_registered_sidebars;
 
+                // Register a sidebar for testing if none exist.
+                if ( empty( $wp_registered_sidebars ) ) {
+                        register_sidebar( array( 'id' => 'test-sidebar' ) );
+                }
+
                 $sidebar_id = array_key_first( $wp_registered_sidebars );
                 $this->assertNotEmpty( $sidebar_id );
@@ -42 +47 @@
         public function test_should_reregister_previous_theme_sidebar() {
                 global $wp_registered_sidebars;
+
+                // Register a sidebar for testing if none exist.
+                if ( empty( $wp_registered_sidebars ) ) {
+                        register_sidebar( array( 'id' => 'test-sidebar' ) );
+                }
 
                 $sidebar_id = array_key_first( $wp_registered_sidebars );