Changeset 61467 for trunk/tests/phpunit/tests/media.php

Timestamp:

01/10/2026 09:45:09 PM (8 months ago)

Author:

dmsnell

Message:

HTML API: Refactor wp_kses_hair() for spec-compliance.

wp_kses_hair() is built around an impressive state machine for parsing the span of text following an HTML tag name and the tag’s closing > into a structured representation of the attributes. Unfortunately that parsing code doesn’t comply with the HTML Living Standard and is prone to mis-parsing attributes, particularly in the presence of malformed inputs.

This patch replaces the existing state machine with the spec-compliant parsing from the HTML API. With a comprehensive test suite covering attribute parsing, the same reliability the Tag Processor affords will be applied to wp_kses_hair(), giving new guarantees not previously available in Core:

• All attribute values are reported fully-normalized, where character references are decoded and then re-encoded in a predictable manner. Only the “big five” syntax characters (“&<>'"”) will remain, and in their named forms.
• All whole values are fully normalized and presented either as boolean attributes without a value, or with double-quoted attribute values.
• All attributes and their values will be properly parsed according to how a browser would parse them, bringing agreement between the server and user agents.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/9248
Discussed in https://core.trac.wordpress.org/ticket/63724

Props adamziel, dmsnell, jonsurrell, jorbin, westonruter.
Fixes #63724.

File:

• trunk/tests/phpunit/tests/media.php (modified) (1 diff)

trunk/tests/phpunit/tests/media.php

@@ -228 +228 @@
                         self::HTML_CONTENT,
                         $mark,
-                        'Test caption content should not contain the mark surround it: check test setup.'
+                        'Test caption content should not contain the mark surrounding it: check test setup.'
                 );