Changeset 61473 for trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

Timestamp:

01/12/2026 12:18:12 PM (5 weeks ago)

Author:

youknowriad

Message:

Global Styles: Lift classic block restrictions.

Enable Global Styles functionality in classic WordPress themes, allowing features like the Font Library to work without requiring a theme.json file.

This change:

• Removes restrictions that prevented classic themes from accessing Global Styles features.
• Enables font functionality in classic themes through the Font Library.
• Fixes Fonts menu not appearing in classic themes by changing its submenu index to avoid collision with Widgets.

Props youknowriad, isabel_brison, ramonopoly.
Fixes #64408.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

@@ -735 +735 @@
      * @covers WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles
      */
-    public function test_get_user_data_from_wp_global_styles_does_not_run_for_theme_without_support() {
-        // The 'default' theme does not support theme.json.
+    public function test_get_user_data_from_wp_global_styles_runs_for_classic_themes() {
+        // The 'default' theme does not support theme.json (classic theme).
         switch_theme( 'default' );
         wp_set_current_user( self::$administrator_id );
         $theme = wp_get_theme();
 
-        $start_queries = get_num_queries();
-
-        // When theme.json is not supported, the method should not run a query and always return an empty result.
-        $user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( $theme );
-        $this->assertEmpty( $user_cpt, 'User CPT is expected to be empty.' );
-        $this->assertSame( 0, get_num_queries() - $start_queries, 'Unexpected SQL query detected for theme without theme.json support.' );
-
+        // Classic themes should now be able to access user global styles data.
+        // When should_create_post is true, it should create a post.
         $user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( $theme, true );
-        $this->assertEmpty( $user_cpt, 'User CPT is expected to be empty.' );
-        $this->assertSame( 0, get_num_queries() - $start_queries, 'Unexpected SQL query detected for theme without theme.json support.' );
+        $this->assertIsArray( $user_cpt, 'User CPT should be an array for classic themes.' );
+        $this->assertArrayHasKey( 'ID', $user_cpt, 'User CPT should have an ID for classic themes.' );
+
+        // Clean up the created post.
+        if ( isset( $user_cpt['ID'] ) ) {
+            wp_delete_post( $user_cpt['ID'], true );
+        }
     }