Changeset 61474 for trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

01/12/2026 09:15:00 PM (8 months ago)

Author:

westonruter

Message:

Code Modernization: Utilize spaceship operator <=> in sort comparison logic.

Some replaced instances also fix a bug where the comparison function should have returned 0 as opposed to 1 or -1 as used in ternaries. This results in a performance improvement.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10717

Props soean, mukesh27, westonruter.
Fixes #64497.

File:

• trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -303 +303 @@
                 $b = $theme_b[ $orderby ];
 
-                if ( $a === $b ) {
-                        return 0;
-                }
-
-                if ( 'DESC' === $order ) {
-                        return ( $a < $b ) ? 1 : -1;
-                } else {
-                        return ( $a < $b ) ? -1 : 1;
-                }
+                return 'DESC' === $order ?
+                        $b <=> $a :
+                        $a <=> $b;
         }