Changeset 61474 for trunk/src/wp-admin/includes/menu.php

Timestamp:

01/12/2026 09:15:00 PM (5 weeks ago)

Author:

westonruter

Message:

Code Modernization: Utilize spaceship operator <=> in sort comparison logic.

Some replaced instances also fix a bug where the comparison function should have returned 0 as opposed to 1 or -1 as used in ternaries. This results in a performance improvement.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10717

Props soean, mukesh27, westonruter.
Fixes #64497.

File:

• trunk/src/wp-admin/includes/menu.php (modified) (1 diff)

trunk/src/wp-admin/includes/menu.php

@@ -328 +328 @@
             return 1;
         } elseif ( isset( $menu_order[ $a ] ) && isset( $menu_order[ $b ] ) ) {
-            if ( $menu_order[ $a ] === $menu_order[ $b ] ) {
-                return 0;
-            }
-            return ( $menu_order[ $a ] < $menu_order[ $b ] ) ? -1 : 1;
+            return $menu_order[ $a ] <=> $menu_order[ $b ];
         } else {
-            return ( $default_menu_order[ $a ] <= $default_menu_order[ $b ] ) ? -1 : 1;
+            return $default_menu_order[ $a ] <=> $default_menu_order[ $b ];
         }
     }