Changeset 61495

Timestamp:

01/17/2026 06:38:20 AM (5 weeks ago)

Author:

westonruter

Message:

Administration: Avoid PHP type error with gmdate() in wp_dashboard_recent_posts().

This fixes an issue when a non-integer is returned by get_the_time( 'U' ) which can occur when a plugin filters get_the_time. In this case, the non-relative date is displayed in the Activity dashboard widget.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10729

Follow-up to [26690], [26242].

Props sabernhardt, vanhoucke, westonruter.
Fixes #64496.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (2 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -1015 +1015 @@
             $time = get_the_time( 'U' );
 
-            if ( gmdate( 'Y-m-d', $time ) === $today ) {
-                $relative = __( 'Today' );
+            if ( ! is_int( $time ) ) {
+                /* translators: Date and time format for recent posts on the dashboard, from a different calendar year, see https://www.php.net/manual/datetime.format.php */
+                $date = get_the_date( __( 'M jS Y' ) );
+            } elseif ( gmdate( 'Y-m-d', $time ) === $today ) {
+                $date = __( 'Today' );
             } elseif ( gmdate( 'Y-m-d', $time ) === $tomorrow ) {
-                $relative = __( 'Tomorrow' );
+                $date = __( 'Tomorrow' );
             } elseif ( gmdate( 'Y', $time ) !== $year ) {
                 /* translators: Date and time format for recent posts on the dashboard, from a different calendar year, see https://www.php.net/manual/datetime.format.php */
-                $relative = date_i18n( __( 'M jS Y' ), $time );
+                $date = date_i18n( __( 'M jS Y' ), $time );
             } else {
                 /* translators: Date and time format for recent posts on the dashboard, see https://www.php.net/manual/datetime.format.php */
-                $relative = date_i18n( __( 'M jS' ), $time );
+                $date = date_i18n( __( 'M jS' ), $time );
             }
 
@@ -1034 +1037 @@
                 '<li><span>%1$s</span> <a href="%2$s" aria-label="%3$s">%4$s</a></li>',
                 /* translators: 1: Relative date, 2: Time. */
-                sprintf( _x( '%1$s, %2$s', 'dashboard' ), $relative, get_the_time() ),
+                sprintf( _x( '%1$s, %2$s', 'dashboard' ), $date, get_the_time() ),
                 $recent_post_link,
                 /* translators: %s: Post title. */