Changeset 61531 for branches/6.9/tests/phpunit/tests/pluggable/wpMail.php

Timestamp:

01/26/2026 07:02:04 PM (3 months ago)

Author:

jorbin

Message:

General: Use legacy content properties for CSS icons.

In modern browsers the CSS content property provides alt text support for assistive technology in the form display / alt text. This introduces support for legacy browsers that do not support the new syntax.

CSS content properties take advantage of the CSS cascade and browsers ignoring values they don't understand by adding duplicate content properties in the form:

content: display;
content: display / alt text;
Modern browsers will use the second property, legacy browsers will use the first.

Follow-up to [60885] for #63603.

Reviewed by wildworks, jorbin.
Merges [61480] to the 6.9 branch.

Props acmoifr, joedolson, jorbin, mydesign78, ov3rfly, peterwilsoncc, presskopp, sabernhardt, siliconforks, swissspidy, threadi, wildworks, wolf45.
Fixes #64350.

Location:

branches/6.9

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/pluggable/wpMail.php (modified) (1 diff)

branches/6.9/tests/phpunit/tests/pluggable/wpMail.php

@@ -412 +412 @@
 
     /**
-     * Test that the Sender field in the SMTP envelope is set by Core.
-     *
-     * A missing Sender field can lead to messages failing DMARC SPF checks.
-     *
-     * @ticket 49687
-     */
-    public function test_wp_mail_sender_set() {
-        wp_mail( 'user@example.org', 'Testing the Sender field', 'The Sender field should have been set.' );
-
-        $mailer = tests_retrieve_phpmailer_instance();
-
-        $this->assertSame( 'wordpress@example.org', $mailer->Sender );
+     * Test that the Sender field in the SMTP envelope is not set by Core.
+     *
+     * Correctly setting the Sender requires knowledge that is not available
+     * to Core. An incorrect value will often lead to messages being rejected
+     * by the receiving MTA, so it's the admin's responsibility to
+     * set it correctly.
+     *
+     * @ticket 37736
+     */
+    public function test_wp_mail_sender_not_set() {
+        wp_mail( 'user@example.org', 'Testing the Sender field', 'The Sender field should not have been set.' );
+
+        $mailer = tests_retrieve_phpmailer_instance();
+
+        $this->assertSame( '', $mailer->Sender );
     }