Changeset 61550 for branches/6.9/src/wp-includes/class-wp-script-modules.php

Timestamp:

01/28/2026 09:28:06 PM (6 months ago)

Author:

jorbin

Message:

Script Loader: Emit notices when enqueueing a script, style, or script module with missing dependencies.

First Developed in ​https://github.com/WordPress/wordpress-develop/pull/10545. Backport developed in ​https://github.com/WordPress/wordpress-develop/pull/10789.

Follow-up to [60999].

Reviewed by jorbin, wildworks.
Merges [61323], [61357], and [61542].

Props deepakprajapati, westonruter, mukeshpanchal27, jorbin, wildworks.
See #63486.
Fixes #64229.

Location:

branches/6.9

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-script-modules.php (modified) (2 diffs)

branches/6.9/src/wp-includes/class-wp-script-modules.php

@@ -70 +70 @@
                 'high',
         );
+
+        /**
+         * List of IDs for script modules encountered which have missing dependencies.
+         *
+         * An ID is added to this list when it is discovered to have missing dependencies. At this time, a warning is
+         * emitted with {@see _doing_it_wrong()}. The ID is then added to this list, so that duplicate warnings don't occur.
+         *
+         * @since 6.9.1
+         * @var string[]
+         */
+        private $modules_with_missing_dependencies = array();
 
         /**
@@ -723 +734 @@
 
                 // If the item requires dependencies that do not exist, fail.
-                if ( count( array_diff( $dependency_ids, array_keys( $this->registered ) ) ) > 0 ) {
+                $missing_dependencies = array_diff( $dependency_ids, array_keys( $this->registered ) );
+                if ( count( $missing_dependencies ) > 0 ) {
+                        if ( ! in_array( $id, $this->modules_with_missing_dependencies, true ) ) {
+                                _doing_it_wrong(
+                                        get_class( $this ) . '::register',
+                                        sprintf(
+                                                /* translators: 1: Script module ID, 2: List of missing dependency IDs. */
+                                                __( 'The script module with the ID "%1$s" was enqueued with dependencies that are not registered: %2$s.' ),
+                                                $id,
+                                                implode( wp_get_list_item_separator(), $missing_dependencies )
+                                        ),
+                                        '6.9.1'
+                                );
+                                $this->modules_with_missing_dependencies[] = $id;
+                        }
+
                         return false;
                 }