Changeset 61550 for branches/6.9/tests/phpunit/tests/script-modules/wpScriptModules.php

Timestamp:

01/28/2026 09:28:06 PM (6 months ago)

Author:

jorbin

Message:

Script Loader: Emit notices when enqueueing a script, style, or script module with missing dependencies.

First Developed in ​https://github.com/WordPress/wordpress-develop/pull/10545. Backport developed in ​https://github.com/WordPress/wordpress-develop/pull/10789.

Follow-up to [60999].

Reviewed by jorbin, wildworks.
Merges [61323], [61357], and [61542].

Props deepakprajapati, westonruter, mukeshpanchal27, jorbin, wildworks.
See #63486.
Fixes #64229.

Location:

branches/6.9

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/script-modules/wpScriptModules.php (modified) (2 diffs)

branches/6.9/tests/phpunit/tests/script-modules/wpScriptModules.php

@@ -2107 +2107 @@
                 );
 
-                $deregister( array( 'b', 'c ' ) );
+                $deregister( array( 'b', 'c' ) );
 
                 // Test that registered dependency in footer doesn't place dependant in footer.
@@ -2356 +2356 @@
                 );
         }
+
+        /**
+         * Tests that a missing script module dependency triggers a _doing_it_wrong() notice.
+         *
+         * @ticket 64229
+         * @covers WP_Script_Modules::sort_item_dependencies
+         */
+        public function test_missing_script_module_dependency_triggers_incorrect_usage() {
+                $expected_incorrect_usage = 'WP_Script_Modules::register';
+                $this->setExpectedIncorrectUsage( $expected_incorrect_usage );
+
+                $this->script_modules->enqueue( 'main-module', '/main-module.js', array( 'missing-mod-dep' ) );
+
+                $markup = get_echo( array( $this->script_modules, 'print_enqueued_script_modules' ) );
+                $this->assertStringNotContainsString( 'main-module.js', $markup, 'Expected script module to be absent.' );
+
+                $this->assertArrayHasKey(
+                        $expected_incorrect_usage,
+                        $this->caught_doing_it_wrong,
+                        'Expected WP_Script_Modules::register to be reported via doing_it_wrong().'
+                );
+
+                // Assert the message mentions the missing dependency handle.
+                $this->assertStringContainsString(
+                        'The script module with the ID "main-module" was enqueued with dependencies that are not registered: missing-mod-dep',
+                        $this->caught_doing_it_wrong[ $expected_incorrect_usage ]
+                );
+        }
 }