Changeset 61553

Timestamp:

01/29/2026 01:05:19 AM (9 days ago)

Author:

peterwilsoncc

Message:

Feeds: Fix backward compatibility of fetch_feed().

In ​simplepie/simplepie#795 handling of multiple feed requests was deprecated, triggering the message Fetching multiple feeds with single SimplePie instance is deprecated since SimplePie 1.9.0, create one SimplePie instance per feed and use SimplePie::merge_items to get a single list of items.

This updates fetch_feed() to handle multiple requests using seperate SimplePie instances in order to retain backward compatibility.

A PHP 8.5 deprecation was throwing notices in the event an empty URL was passed to fetch_feed(), Using null as an array offset is deprecated, use an empty string instead.

This includes a workaround pending the release of a SimplePie version including ​simplepie/simplepie#949.

Reviewed by jorbin.
Merges [61551] to the 6.9 branch.

Fixes #64136.
Props audrasjb, jorbin, muryam, oglekler, ozgursar, presskopp, swissspidy, westonruter, wildworks, peterwilsoncc.

Location:

branches/6.9

Files:

• . (modified) (1 prop)
• src/wp-includes/feed.php (modified) (2 diffs)
• tests/phpunit/tests/feed/fetchFeed.php (modified) (2 diffs)

branches/6.9/src/wp-includes/feed.php

@@ -833 +833 @@
     $feed->get_registry()->register( SimplePie\File::class, 'WP_SimplePie_File', true );
 
-    $feed->set_feed_url( $url );
     /** This filter is documented in wp-includes/class-wp-feed-cache-transient.php */
     $feed->set_cache_duration( apply_filters( 'wp_feed_cache_transient_lifetime', 12 * HOUR_IN_SECONDS, $url ) );
@@ -847 +846 @@
     do_action_ref_array( 'wp_feed_options', array( &$feed, $url ) );
 
+    if ( empty( $url ) ) {
+        /*
+         * @todo: Set $url to empty string once supported by SimplePie.
+         *
+         * The early return without proceeding is to work around a PHP 8.5
+         * deprecation issue resolved in https://github.com/simplepie/simplepie/pull/949
+         *
+         * To avoid the duplicate code, this block can be replaced with `$url = '';` once SimplePie
+         * is upgraded to a version that includes the fix.
+         */
+        $feed->init();
+        $feed->set_output_encoding( get_bloginfo( 'charset' ) );
+
+        if ( $feed->error() ) {
+            return new WP_Error( 'simplepie-error', $feed->error() );
+        }
+
+        return $feed;
+    } elseif ( is_array( $url ) && count( $url ) === 1 ) {
+        $url = array_shift( $url );
+    } elseif ( is_array( $url ) ) {
+        $feeds            = array();
+        $simplepie_errors = array();
+        foreach ( $url as $feed_url ) {
+            $simplepie_instance = clone $feed;
+            $simplepie_instance->set_feed_url( $feed_url );
+            $simplepie_instance->init();
+            $simplepie_instance->set_output_encoding( get_bloginfo( 'charset' ) );
+
+            if ( $simplepie_instance->error() ) {
+                $simplepie_errors[] = sprintf(
+                    /* translators: %1$s is the feed URL, %2$s is the error message. */
+                    __( 'Error fetching feed %1$s: %2$s' ),
+                    esc_url( $feed_url ),
+                    $simplepie_instance->error()
+                );
+                unset( $simplepie_instance );
+                continue;
+            }
+
+            $feeds[] = $simplepie_instance;
+            unset( $simplepie_instance );
+        }
+
+        if ( ! empty( $simplepie_errors ) ) {
+            return new WP_Error( 'simplepie-error', $simplepie_errors );
+        }
+
+        $feed->init();
+        $feed->data['items'] = SimplePie\SimplePie::merge_items( $feeds );
+        return $feed;
+    }
+
+    $feed->set_feed_url( $url );
     $feed->init();
     $feed->set_output_encoding( get_bloginfo( 'charset' ) );

branches/6.9/tests/phpunit/tests/feed/fetchFeed.php

@@ -35 +35 @@
 
     /**
+     * Ensure WP_Error object returned for 404 response.
+     *
+     * @ticket 64136
+     */
+    public function test_fetch_feed_returns_error_for_404_response() {
+        // Priority 15 to ensure this runs after the mocked_rss_response filter.
+        add_filter( 'pre_http_request', array( $this, 'mocked_rss_404_error_response' ), 15 );
+
+        $feed = fetch_feed( 'https://example.org/news/feed/' );
+
+        $this->assertWPError( $feed, 'A WP_Error object is expected for failing requests.' );
+        $this->assertSame( 'simplepie-error', $feed->get_error_code() );
+    }
+
+    /**
+     * Ensure fetch_feed() returns WP_Error if any feed errors.
+     *
+     * @ticket 64136
+     */
+    public function test_fetch_feed_multiple_returns_error_if_any_feed_errors() {
+        // Priority 15 to ensure this runs after the mocked_rss_response filter.
+        add_filter( 'pre_http_request', array( $this, 'mocked_rss_404_error_response' ), 15 );
+        add_filter(
+            'pre_http_request',
+            /**
+             * Remove the 404 error response after the first call.
+             */
+            function ( $response ) {
+                remove_filter( 'pre_http_request', array( $this, 'mocked_rss_404_error_response' ), 15 );
+
+                return $response;
+            },
+            20 // Priority 20 to ensure it runs after the 404 error response.
+        );
+
+        $feed = fetch_feed( array( 'https://example.org/news/feed/', 'https://wordpress.org/news/feed/' ) );
+
+        $this->assertWPError( $feed, 'A WP_Error object is expected for any failing requests.' );
+        $this->assertSame( 'simplepie-error', $feed->get_error_code() );
+        $this->assertCount( 1, $feed->get_error_messages()[0], 'There should be one error message for the failed feed.' );
+    }
+
+    /**
+     * Ensure fetch_feed() includes messages for all feeds that error.
+     *
+     * @ticket 64136
+     */
+    public function test_fetch_feed_multiple_returns_error_if_all_feeds_error() {
+        // Priority 15 to ensure this runs after the mocked_rss_response filter.
+        add_filter( 'pre_http_request', array( $this, 'mocked_rss_404_error_response' ), 15 );
+        $feed = fetch_feed( array( 'https://example.org/news/feed/', 'https://example.com/news/feed/' ) );
+
+        $this->assertWPError( $feed, 'A WP_Error object is expected for failing requests.' );
+        $this->assertSame( 'simplepie-error', $feed->get_error_code() );
+        $this->assertCount( 2, $feed->get_error_messages()[0], 'There should be two error messages, one for each failed feed.' );
+    }
+
+    /**
+     * Ensure fetch_feed() returns a SimplePie object for an empty URL (string).
+     *
+     * @ticket 64136
+     */
+    public function test_fetch_feed_returns_a_simplepie_object_for_unspecified_url_string() {
+        $feed = fetch_feed( '' );
+
+        $this->assertInstanceOf( 'SimplePie\\SimplePie', $feed );
+    }
+
+    /**
+     * Ensure fetch_feed() returns a SimplePie object for an empty URL (array).
+     *
+     * @ticket 64136
+     */
+    public function test_fetch_feed_returns_a_simplepie_object_for_unspecified_url_array() {
+        $feed = fetch_feed( array() );
+
+        $this->assertInstanceOf( 'SimplePie\\SimplePie', $feed );
+    }
+
+    /**
+     * Ensure fetch_feed() accepts multiple feeds.
+     *
+     * The main purpose of this test is to ensure that the SimplePie deprecation warning
+     * is not thrown when requesting multiple feeds.
+     *
+     * Secondly it confirms that the markup of the first two items match as they will
+     * both be from the same feed URL as the array contains the WordPress News feed twice.
+     *
+     * @ticket 64136
+     */
+    public function test_fetch_feed_supports_multiple_feeds() {
+        $feed    = fetch_feed( array( 'https://wordpress.org/news/feed/', 'https://wordpress.org/news/feed/atom/' ) );
+        $content = array();
+
+        foreach ( $feed->get_items( 0, 2 ) as $item ) {
+            $content[] = $item->get_content();
+        }
+
+        $this->assertEqualHTML( $content[0], $content[1], null, 'The contents of the first two items should be identical.' );
+        $this->assertCount( 20, $feed->get_items(), 'The feed should contain 20 items.' );
+    }
+
+    /**
      * Ensure that fetch_feed() is cached on second and subsequent calls.
      *
@@ -112 +215 @@
         );
     }
+
+    /**
+     * Mock 404 error response for `fetch_feed()`.
+     *
+     * This simulates a 404 response to test error handling in `fetch_feed()`.
+     *
+     * @return array Mocked 404 error response data.
+     */
+    public function mocked_rss_404_error_response() {
+        return array(
+            'headers'  => new WpOrg\Requests\Utility\CaseInsensitiveDictionary(),
+            'body'     => '',
+            'response' => array(
+                'code'    => 404,
+                'message' => 'Not Found',
+            ),
+            'cookies'  => array(),
+            'filename' => null,
+        );
+    }
 }