Context Navigation

← Previous Change
Next Change →

class-wp-query.php

Timestamp:

02/04/2026 06:51:51 PM (5 months ago)

Author:

westonruter

Message:

Formatting: Deprecate the addslashes_gpc() function.

This deprecates addslashes_gpc() in favor of wp_slash(), as the former is just a wrapper for the latter. The three remaining uses of addslashes_gpc() (in WP_Query) have been replaced with wp_slash(). Unit tests are added to verify that they have the same behavior.

Developed in https://github.com/WordPress/wordpress-develop/pull/10771

Follow-up to [23591], [23555].

Props rutviksavsani, audrasjb, westonruter, mindctrl, johnbillion.
See #21767.
Fixes #64539.

File:

: 1 edited

trunk/src/wp-includes/class-wp-query.php (modified) (3 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/class-wp-query.php

-              r61470
+              r61590
                 if ( ! empty( $query_vars['author'] ) && '0' != $query_vars['author'] ) {
                         $query_vars['author'] = addslashes_gpc( '' . urldecode( $query_vars['author'] ) );
+                        $query_vars['author'] = wp_slash( '' . urldecode( $query_vars['author'] ) );
                         $authors              = array_unique( array_map( 'intval', preg_split( '/[,\s]+/', $query_vars['author'] ) ) );
                         sort( $authors );
 …
                         if ( is_array( $query_vars['orderby'] ) ) {
                                 foreach ( $query_vars['orderby'] as $_orderby => $order ) {
                                         $orderby = addslashes_gpc( urldecode( $_orderby ) );
+                                        $orderby = wp_slash( urldecode( $_orderby ) );
                                         $parsed  = $this->parse_orderby( $orderby );
 …
                         } else {
                                 $query_vars['orderby'] = urldecode( $query_vars['orderby'] );
                                 $query_vars['orderby'] = addslashes_gpc( $query_vars['orderby'] );
+                                $query_vars['orderby'] = wp_slash( $query_vars['orderby'] );
                                 foreach ( explode( ' ', $query_vars['orderby'] ) as $i => $orderby ) {

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 61590 for trunk/src/wp-includes/class-wp-query.php

Legend:

trunk/src/wp-includes/class-wp-query.php

Download in other formats: