Context Navigation

← Previous Change
Next Change →

wpSlash.php

Timestamp:

02/04/2026 06:51:51 PM (5 months ago)

Author:

westonruter

Message:

Formatting: Deprecate the addslashes_gpc() function.

This deprecates addslashes_gpc() in favor of wp_slash(), as the former is just a wrapper for the latter. The three remaining uses of addslashes_gpc() (in WP_Query) have been replaced with wp_slash(). Unit tests are added to verify that they have the same behavior.

Developed in https://github.com/WordPress/wordpress-develop/pull/10771

Follow-up to [23591], [23555].

Props rutviksavsani, audrasjb, westonruter, mindctrl, johnbillion.
See #21767.
Fixes #64539.

File:

: 1 edited

trunk/tests/phpunit/tests/formatting/wpSlash.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/formatting/wpSlash.php

-              r56547
+              r61590
                 $this->assertSame( array( $new ), wp_slash( array( $old ) ) ); // Non-keyed.
+        }
+        /**
+         * Tests that addslashes_gpc() returns the same result as wp_slash() for strings.
+         *
+         * @ticket 64539
+         * @covers ::addslashes_gpc
+         * @expectedDeprecated addslashes_gpc
+         */
+        public function test_addslashes_gpc_matches_wp_slash_for_strings() {
+                $input = "String with 'quotes' and \"double quotes\"";
+                $this->assertSame( wp_slash( $input ), addslashes_gpc( $input ) );
+        }
+        /**
+         * Tests that addslashes_gpc() returns the same result as wp_slash() for arrays.
+         *
+         * @ticket 64539
+         * @covers ::addslashes_gpc
+         * @expectedDeprecated addslashes_gpc
+         */
+        public function test_addslashes_gpc_matches_wp_slash_for_arrays() {
+                $input = array(
+                        'field1' => "Value with 'apostrophe'",
+                        'field2' => 'Value with "quotes"',
+                        'field3' => 'user@example.com',
+                        'nested' => array(
+                                'key1' => 'Nested value with \\ backslash',
+                                'key2' => array( 'deeply', 'nested', 'array' ),
+                        ),
+                );
+                $this->assertSame( wp_slash( $input ), addslashes_gpc( $input ) );
+        }
+}

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 61590 for trunk/tests/phpunit/tests/formatting/wpSlash.php

Legend:

trunk/tests/phpunit/tests/formatting/wpSlash.php

Download in other formats: