Changeset 61602 for trunk/tests/phpunit/tests/abilities-api/wpAbilitiesRegistry.php

Timestamp:

02/09/2026 04:59:52 PM (2 months ago)

Author:

jorgefilipecosta

Message:

Abilities API: Allow nested namespace ability names (2-4 segments).

Expand ability name validation from exactly 2 segments (namespace/ability) to 2-4 segments, enabling names like my-plugin/resource/find and my-plugin/resource/sub/find.
This allows plugins to organize abilities into logical resource groups. The validation regex changes from /^[a-z0-9-]+\/[a-z0-9-]+$/ to /^[a-z0-9-]+(?:\/[a-z0-9-]+){1,3}$/, which accepts the first segment plus 1-3 additional slash-delimited segments.
Updates the validation regex, error messages, docblocks, and adds corresponding unit and REST API tests.

Props jorgefilipecosta, justlevine, jorbin.
Fixes #64596.

File:

• trunk/tests/phpunit/tests/abilities-api/wpAbilitiesRegistry.php (modified) (1 diff)

trunk/tests/phpunit/tests/abilities-api/wpAbilitiesRegistry.php

@@ -138 +138 @@
 
     /**
+     * Should accept ability name with 3 segments (2 slashes).
+     *
+     * @ticket 64098
+     *
+     * @covers WP_Abilities_Registry::register
+     */
+    public function test_register_valid_name_with_three_segments() {
+        $result = $this->registry->register( 'test/sub/add-numbers', self::$test_ability_args );
+        $this->assertInstanceOf( WP_Ability::class, $result );
+        $this->assertSame( 'test/sub/add-numbers', $result->get_name() );
+    }
+
+    /**
+     * Should accept ability name with 4 segments (3 slashes).
+     *
+     * @ticket 64098
+     *
+     * @covers WP_Abilities_Registry::register
+     */
+    public function test_register_valid_name_with_four_segments() {
+        $result = $this->registry->register( 'test/sub/deep/add-numbers', self::$test_ability_args );
+        $this->assertInstanceOf( WP_Ability::class, $result );
+        $this->assertSame( 'test/sub/deep/add-numbers', $result->get_name() );
+    }
+
+    /**
+     * Should reject ability name with 5 segments (exceeds maximum of 4).
+     *
+     * @ticket 64098
+     *
+     * @covers WP_Abilities_Registry::register
+     *
+     * @expectedIncorrectUsage WP_Abilities_Registry::register
+     */
+    public function test_register_invalid_name_with_five_segments() {
+        $result = $this->registry->register( 'test/a/b/c/too-deep', self::$test_ability_args );
+        $this->assertNull( $result );
+    }
+
+    /**
+     * Should reject ability name with empty segments (double slashes).
+     *
+     * @ticket 64098
+     *
+     * @covers WP_Abilities_Registry::register
+     *
+     * @expectedIncorrectUsage WP_Abilities_Registry::register
+     */
+    public function test_register_invalid_name_with_empty_segment() {
+        $result = $this->registry->register( 'test//add-numbers', self::$test_ability_args );
+        $this->assertNull( $result );
+    }
+
+    /**
+     * Should reject ability name with trailing slash.
+     *
+     * @ticket 64098
+     *
+     * @covers WP_Abilities_Registry::register
+     *
+     * @expectedIncorrectUsage WP_Abilities_Registry::register
+     */
+    public function test_register_invalid_name_with_trailing_slash() {
+        $result = $this->registry->register( 'test/add-numbers/', self::$test_ability_args );
+        $this->assertNull( $result );
+    }
+
+    /**
      * Should reject ability registration without a label.
      *