Changeset 61603

Timestamp:

02/09/2026 05:08:13 PM (2 months ago)

Author:

jorgefilipecosta

Message:

Block Supports: Prevent fatal error in WP_Duotone when the duotone attribute is an array.

Adds type checks to get_slug_from_attribute(), is_preset(), and get_all_global_style_block_names() to handle cases where the duotone attribute is an array of custom colors instead of a preset reference string.
This prevents an error when preg_match() receives an array instead of a string.

Props jorgefilipecosta, westonruter, xavilc.
Fixes #64612.

Location:

trunk

Files:

• src/wp-includes/class-wp-duotone.php (modified) (3 diffs)
• tests/phpunit/tests/block-supports/duotone.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-duotone.php

@@ -547 +547 @@
      * @since 6.3.0
      *
-     * @param string $duotone_attr The duotone attribute from a block.
-     * @return string The slug of the duotone preset or an empty string if no slug is found.
+     * @param string|string[] $duotone_attr The duotone attribute from a block.
+     * @return string The slug of the duotone preset or an empty string if no slug is found (including when an array was passed).
      */
     private static function get_slug_from_attribute( $duotone_attr ) {
+        if ( ! is_string( $duotone_attr ) ) {
+            return '';
+        }
+
         // Uses Branch Reset Groups `(?|…)` to return one capture group.
         preg_match( '/(?|var:preset\|duotone\|(\S+)|var\(--wp--preset--duotone--(\S+)\))/', $duotone_attr, $matches );
@@ -567 +571 @@
      *
      * @param string $duotone_attr The duotone attribute from a block.
-     * @return bool True if the duotone preset present and valid.
+     * @param string|string[] $duotone_attr The duotone attribute from a block.
      */
     private static function is_preset( $duotone_attr ) {
+        if ( ! is_string( $duotone_attr ) ) {
+            return false;
+        }
+
         $slug      = self::get_slug_from_attribute( $duotone_attr );
         $filter_id = self::get_filter_id( $slug );
@@ -1051 +1059 @@
             }
             // If it has a duotone filter preset, save the block name and the preset slug.
+            // Only process if it's a string (preset reference), not an array (custom colors).
+            if ( ! is_string( $duotone_attr ) ) {
+                continue;
+            }
+
             $slug = self::get_slug_from_attribute( $duotone_attr );
 

trunk/tests/phpunit/tests/block-supports/duotone.php

@@ -94 +94 @@
             'css-var-spaces'                  => array( 'var(--wp--preset--duotone--    ', '' ),
             'pipe-slug-spaces'                => array( 'var:preset|duotone|  ', '' ),
+            'array-of-colors'                 => array( array( '#000000', '#ffffff' ), '' ),
+            'empty-array'                     => array( array(), '' ),
         );
     }
@@ -165 +167 @@
             'css-var-missing-end-parenthesis' => array( 'var(--wp--preset--duotone--blue-orange', false ),
             'invalid'                         => array( 'not a valid attribute', false ),
+            'array-of-colors'                 => array( array( '#000000', '#ffffff' ), false ),
+            'empty-array'                     => array( array(), false ),
         );
     }