Changeset 61670 for trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

Timestamp:

02/18/2026 04:38:42 AM (6 months ago)

Author:

westonruter

Message:

Customize: Ensure WP_Customize_Setting::update() and subclass overrides return consistent types.

This addresses PHPStan type check issues.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10952

Props westonruter, peterwilsoncc, justlevine.
See #64238, #61175.

File:

• trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php (modified) (9 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

@@ -760 +760 @@
          *
          * @since 4.3.0
+         * @since 7.0.0 Return type updated from null|void to bool for compatibility with base class.
          *
          * @see wp_update_nav_menu_item()
@@ -766 +767 @@
          *                           entirely. See WP_Customize_Nav_Menu_Item_Setting::$default for what the value
          *                           should consist of.
-         * @return null|void
+         * @return bool Whether updated.
          */
         protected function update( $value ) {
                 if ( $this->is_updated ) {
-                        return;
+                        return ( 'error' !== $this->update_status );
                 }
 
@@ -807 +808 @@
                                         $this->update_status = 'error';
                                         $this->update_error  = new WP_Error( 'unexpected_nav_menu_setting' );
-                                        return;
+                                        return false;
                                 }
 
@@ -813 +814 @@
                                         $this->update_status = 'error';
                                         $this->update_error  = new WP_Error( 'nav_menu_setting_failure' );
-                                        return;
+                                        return false;
                                 }
 
@@ -819 +820 @@
                                         $this->update_status = 'error';
                                         $this->update_error  = new WP_Error( 'unexpected_previous_term_id' );
-                                        return;
+                                        return false;
                                 }
 
@@ -833 +834 @@
                                         $this->update_status = 'error';
                                         $this->update_error  = new WP_Error( 'unexpected_nav_menu_item_setting' );
-                                        return;
+                                        return false;
                                 }
 
@@ -839 +840 @@
                                         $this->update_status = 'error';
                                         $this->update_error  = new WP_Error( 'nav_menu_item_setting_failure' );
-                                        return;
+                                        return false;
                                 }
 
@@ -845 +846 @@
                                         $this->update_status = 'error';
                                         $this->update_error  = new WP_Error( 'unexpected_previous_post_id' );
-                                        return;
+                                        return false;
                                 }
 
@@ -887 +888 @@
                         }
                 }
+
+                return ( 'error' !== $this->update_status );
         }