Changeset 61670 for trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php

Timestamp:

02/18/2026 04:38:42 AM (6 months ago)

Author:

westonruter

Message:

Customize: Ensure WP_Customize_Setting::update() and subclass overrides return consistent types.

This addresses PHPStan type check issues.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10952

Props westonruter, peterwilsoncc, justlevine.
See #64238, #61175.

File:

• trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php (modified) (3 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php

@@ -467 +467 @@
          *
          * @since 4.3.0
+         * @since 7.0.0 Return type updated from null|void to bool for compatibility with base class.
          *
          * @see wp_update_nav_menu_object()
@@ -479 +480 @@
          *     @type bool   $auto_add    Whether pages will auto_add to this menu. Default false.
          * }
-         * @return null|void
+         * @return bool Whether updated.
          */
         protected function update( $value ) {
                 if ( $this->is_updated ) {
-                        return;
+                        return ( 'error' !== $this->update_status );
                 }
 
@@ -583 +584 @@
                         }
                 }
+
+                return ( 'error' !== $this->update_status );
         }