Changeset 61715

Timestamp:

02/22/2026 10:35:20 PM (6 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Use named data provider in a balanceTags() test.

Follow-up to [661/tests], [45929].

Props rahmohn.
See #64225.

File:

• trunk/tests/phpunit/tests/formatting/balanceTags.php (modified) (1 diff)

trunk/tests/phpunit/tests/formatting/balanceTags.php

@@ -206 +206 @@
 
     /**
+     * Tests closing unknown single tags.
+     *
      * @ticket 1597
-     */
-    public function test_closes_unknown_single_tags_with_closing_tag() {
-
-        $inputs   = array(
-            '<strong/>',
-            '<em />',
-            '<p class="main1"/>',
-            '<p class="main2" />',
-            '<STRONG/>',
-        );
-        $expected = array(
-            '<strong></strong>',
-            '<em></em>',
-            '<p class="main1"></p>',
-            '<p class="main2"></p>',
+     * @dataProvider data_unknown_single_tags_with_closing_tag
+     */
+    public function test_closes_unknown_single_tags_with_closing_tag( $input, $expected ) {
+        $this->assertSame( $expected, balanceTags( $input, true ) );
+    }
+
+    /**
+     * Data provider for test_closes_unknown_single_tags_with_closing_tag.
+     *
+     * @return array<string, array<string, string>>
+     */
+    public function data_unknown_single_tags_with_closing_tag() {
+        return array(
+            'default'              => array( '<strong/>', '<strong></strong>' ),
+            'with-space'           => array( '<em />', '<em></em>' ),
+            'with-class'           => array( '<p class="main1"/>', '<p class="main1"></p>' ),
+            'with-class-and-space' => array( '<p class="main2" />', '<p class="main2"></p>' ),
             // Valid tags are transformed to lowercase.
-            '<strong></strong>',
-        );
-
-        foreach ( $inputs as $key => $input ) {
-            $this->assertSame( $expected[ $key ], balanceTags( $inputs[ $key ], true ) );
-        }
+            'uppercase'            => array( '<STRONG/>', '<strong></strong>' ),
+        );
     }