Changeset 61727

Timestamp:

02/24/2026 10:42:27 PM (6 weeks ago)

Author:

SergeyBiryukov

Message:

Code Quality: Correct return statement in WP_Query::setup_postdata().

This reflects that the method can return both true (success) and false (failure).

Follow-up to [32620], [34089], [44941].

Props huzaifaalmesbah, westonruter.
See #64238.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -4817 +4817 @@
      *
      * @param WP_Post|object|int $post WP_Post instance or Post ID/object.
-     * @return true True when finished.
+     * @return bool True on success, false on failure.
      */
     public function setup_postdata( $post ) {
@@ -4827 +4827 @@
 
         if ( ! $post ) {
-            return;
+            return false;
         }
 
         $elements = $this->generate_postdata( $post );
         if ( false === $elements ) {
-            return;
+            return false;
         }