Context Navigation

← Previous Change
Next Change →

class-wp-http-polling-sync-server.php

Timestamp:

03/05/2026 09:23:25 AM (4 months ago)

Author:

ellatrix

Message:

Real-time collaboration: prevent fall-through in sync polling server.

When a user sends a stale compaction update to WP_HTTP_Polling_Sync_Server, it falls through the switch statement and results in a rest_invalid_update_type error (bad request).

This generally has no ill effect since the compaction request is rescinded on the next polling cycle, but it could cause confusion for users who are monitoring client-side requests or server logs.

To fix, replace the break after the $has_newer_compaction check with return true so that the stale compaction is silently discarded instead of falling through. Covered by unit test.

Developed in: https://github.com/WordPress/wordpress-develop/pull/11118.
Syncs: https://github.com/WordPress/gutenberg/pull/76060.

Fixes #64781.
Props czarate, mindctrl.

File:

: 1 edited

trunk/src/wp-includes/collaboration/class-wp-http-polling-sync-server.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/collaboration/class-wp-http-polling-sync-server.php

-              r61838
+              r61839
                                         return $this->add_update( $room, $client_id, $type, $data );
+                                }
+                                break;
+                                // Reaching this point means there's a newer compaction, so we can
+                                // silently ignore this one.
+                                return true;
                         case self::UPDATE_TYPE_SYNC_STEP1:

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 61839 for trunk/src/wp-includes/collaboration/class-wp-http-polling-sync-server.php

Legend:

trunk/src/wp-includes/collaboration/class-wp-http-polling-sync-server.php

Download in other formats: