Changeset 61857 for trunk/src/wp-includes/functions.php

Timestamp:

03/06/2026 08:04:31 PM (2 months ago)

Author:

dmsnell

Message:

Functions: Memoize wp_normalize_path().

wp_normalize_path() is called thousands of times on a given request. This patch adds memoization via a function-local static variable. This reduces the call count to the underlying wp_is_stream() function, and measured in testing around a 66% cache hit rate.

In testing, for a site making 4000 calls to wp_normalize_path(), this patch led to a reduction in runtime from 1.4 ms to 0.4 ms on the test computer. While small, this time occurs early in the hotpath of the loading WordPress.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/10770
Discussed in: https://core.trac.wordpress.org/ticket/64538

Props dmsnell, josephscott, mreishus, westonruter.
Fixes #64538.

File:

• trunk/src/wp-includes/functions.php (modified) (3 diffs)

trunk/src/wp-includes/functions.php

@@ -2180 +2180 @@
  * @since 4.5.0 Allows for Windows network shares.
  * @since 4.9.7 Allows for PHP file wrappers.
+ * @since 7.0.0 Uses a static cache to store normalized paths.
  *
  * @param string $path Path to normalize.
  * @return string Normalized path.
  */
-function wp_normalize_path( $path ) {
-    $wrapper = '';
+function wp_normalize_path( $path ): string {
+    $path = (string) $path;
+
+    static $cache = array();
+    if ( isset( $cache[ $path ] ) ) {
+        return $cache[ $path ];
+    }
+
+    $original_path = $path;
+    $wrapper       = '';
 
     if ( wp_is_stream( $path ) ) {
@@ -2197 +2206 @@
 
     // Replace multiple slashes down to a singular, allowing for network shares having two slashes.
-    $path = preg_replace( '|(?<=.)/+|', '/', $path );
+    $path = (string) preg_replace( '|(?<=.)/+|', '/', $path );
 
     // Windows paths should uppercase the drive letter.
@@ -2204 +2213 @@
     }
 
-    return $wrapper . $path;
+    $cache[ $original_path ] = $wrapper . $path;
+    return $cache[ $original_path ];
 }