Changeset 62027

Timestamp:

03/14/2026 04:00:01 PM (3 months ago)

Author:

joedolson

Message:

Media: Fix logic when checking IPTC alt text meta data.

Fix two conditional checks for validity of data when importing alt text from IPTC meta data. Strictly compare the results of strpos() as a boolean, rather than treating 0 as false; return string if file_get_contents() returns false.

Props suhan2411, pbiron, alexodiy, joedolson.
Fixes #64849.

File:

• trunk/src/wp-admin/includes/image.php (modified) (1 diff)

trunk/src/wp-admin/includes/image.php

@@ -1089 +1089 @@
     $alt_text     = '';
     $img_contents = file_get_contents( $file );
+
+    if ( false === $img_contents ) {
+        return $alt_text;
+    }
+
     // Find the start and end positions of the XMP metadata.
     $xmp_start = strpos( $img_contents, '<x:xmpmeta' );
     $xmp_end   = strpos( $img_contents, '</x:xmpmeta>' );
 
-    if ( ! $xmp_start || ! $xmp_end ) {
+    if ( false === $xmp_start || false === $xmp_end ) {
         // No XMP metadata found.
         return $alt_text;