Changeset 62070

Timestamp:

03/19/2026 09:16:06 PM (2 months ago)

Author:

luisherranz

Message:

Interactivity API: fix data-wp-bind skipping valid directives after encountering an invalid one

Change return to continue in data_wp_bind_processor so that when an element has multiple data-wp-bind directives and one is invalid (empty suffix or unique ID), the invalid entry is skipped instead of causing the entire function to exit, allowing valid directives on the same element to still be processed.

Props DAreRodz, ozgursar, alexodiy.
Fixes #64518.

Location:

trunk

Files:

• src/wp-includes/interactivity-api/class-wp-interactivity-api.php (modified) (1 diff)
• tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-bind.php (modified) (2 diffs)

trunk/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

@@ -1027 +1027 @@
             foreach ( $entries as $entry ) {
                 if ( empty( $entry['suffix'] ) || null !== $entry['unique_id'] ) {
-                        return;
+                        continue;
                 }
 

trunk/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-bind.php

@@ -136 +136 @@
 
     /**
+     * Tests that `data-wp-bind` ignores directives with no suffix but still
+     * processes valid bind directives on the same element.
+     *
+     * @ticket 64518
+     *
+     * @covers ::process_directives
+     */
+    public function test_wp_bind_ignores_empty_suffix_but_processes_valid_binds() {
+        $html    = '<div data-wp-bind="myPlugin::state.id" data-wp-bind--id="myPlugin::state.id">Text</div>';
+        list($p) = $this->process_directives( $html );
+        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
+    }
+
+    /**
      * Tests that `data-wp-bind` does nothing when referencing non-existent
      * references.
@@ -417 +431 @@
         $this->assertNull( $p->get_attribute( 'id---unique-id' ) );
     }
+
+    /**
+     * Tests that `data-wp-bind` ignores directives with unique IDs but still
+     * processes valid bind directives on the same element.
+     *
+     * @ticket 64518
+     *
+     * @covers ::process_directives
+     */
+    public function test_wp_bind_ignores_unique_id_but_processes_valid_binds() {
+        $html    = '<div data-wp-bind--id---unique-id="myPlugin::state.id" data-wp-bind--id="myPlugin::state.id">Text</div>';
+        list($p) = $this->process_directives( $html );
+        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
+    }
 }