Changeset 62157

Timestamp:

03/27/2026 12:32:38 AM (7 months ago)

Author:

desrosj

Message:

Build/Test Tools: Remove PHP requirement for the build script.

In [61873], the build script started failing in some environemnts due to logic that added a requirement for php-cli.

While WordPress itself cannot be run without PHP, the build script has never required PHP to be present to prepare wordpress-develop for use. This adjusts the relevant code to make use of the php-array-reader package instead.

Reviewed by peterwilsoncc.

Props dmsnell, peterwilsoncc, gaisma22, SirLouen, sabernhardt, manhar.
Fixes #64925. See #64393.

Location:

trunk

Files:

• package-lock.json (modified) (2 diffs)
• package.json (modified) (1 diff)
• tools/gutenberg/copy.js (modified) (4 diffs)

trunk/package-lock.json

@@ -80 +80 @@
                                 "install-changed": "1.1.0",
                                 "json2php": "0.0.12",
+                                "php-array-reader": "2.1.3",
                                 "postcss": "8.5.8",
                                 "prettier": "npm:wp-prettier@3.0.3",
@@ -26138 +26139 @@
                         "dev": true
                 },
+                "node_modules/php-array-reader": {
+                        "version": "2.1.3",
+                        "resolved": "https://registry.npmjs.org/php-array-reader/-/php-array-reader-2.1.3.tgz",
+                        "integrity": "sha512-FjgMmNfnbi76wsbzO/dWEeySt0WZpxv8q/7RH0XFPyNLxsfJSf97KKe/4Rgdmx/XRDGlbl8THU5ayKwGE3Xqrw==",
+                        "dev": true,
+                        "license": "MIT",
+                        "dependencies": {
+                                "php-parser": "^3.1.5"
+                        }
+                },
+                "node_modules/php-parser": {
+                        "version": "3.5.0",
+                        "resolved": "https://registry.npmjs.org/php-parser/-/php-parser-3.5.0.tgz",
+                        "integrity": "sha512-EHdzSckQNP86jQRCEsMYhs+YzS4BfvfxnyhvzHVhVRoRUGEMFi8f3xKfuS9xdChBazZSyvb10SZbqhYQLGBcQg==",
+                        "dev": true,
+                        "license": "BSD-3-Clause"
+                },
                 "node_modules/picocolors": {
                         "version": "1.1.1",

trunk/package.json

@@ -67 +67 @@
                 "install-changed": "1.1.0",
                 "json2php": "0.0.12",
+                "php-array-reader": "2.1.3",
                 "postcss": "8.5.8",
                 "prettier": "npm:wp-prettier@3.0.3",

trunk/tools/gutenberg/copy.js

@@ -10 +10 @@
  */
 
-const child_process = require( 'child_process' );
 const fs = require( 'fs' );
 const path = require( 'path' );
 const json2php = require( 'json2php' );
+const { fromString } = require( 'php-array-reader' );
 
 // Paths.
@@ -26 +26 @@
 const args = process.argv.slice( 2 );
 const buildDirArg = args.find( ( arg ) => arg.startsWith( '--build-dir=' ) );
-const buildTarget = buildDirArg
-        ? buildDirArg.split( '=' )[ 1 ]
-        : args.includes( '--dev' )
-        ? 'src'
-        : 'build';
+const buildTarget = 'src';
 
 const wpIncludesDir = path.join( rootDir, buildTarget, 'wp-includes' );
@@ -79 +75 @@
  * value into a native JavaScript value (limited by JSON serialization).
  *
- * @throws Error when PHP source file unable to be read, or PHP is unavailable.
+ * @throws Error when PHP source file unable to be read or parsed.
  *
  * @param {string} phpFilepath Absolute path of PHP file returning a single value.
@@ -85 +81 @@
  */
 function readReturnedValueFromPHPFile( phpFilepath ) {
-        const results = child_process.spawnSync(
-                'php',
-                [ '-r', '$path = file_get_contents( "php://stdin" ); if ( ! is_file( $path ) ) { die( 1 ); } try { $data = require $path; } catch ( \\Throwable $e ) { die( 2 ); } $json = json_encode( $data ); if ( ! is_string( $json ) ) { die( 3 ); } echo $json;' ],
-                {
-                        encoding: 'utf8',
-                        input: phpFilepath,
-                }
-        );
-
-        switch ( results.status ) {
-                case 0:
-                        return JSON.parse( results.stdout );
-
-                case 1:
-                        throw new Error( `Could not read PHP source file: '${ phpFilepath }'` );
-
-                case 2:
-                        throw new Error( `PHP source file did not return value when imported: '${ phpFilepath }'` );
-
-                case 3:
-                        throw new Error( `Could not serialize PHP source value into JSON: '${ phpFilepath }'` );
-        }
-
-        throw new Error( `Unknown error while reading PHP source file: '${ phpFilepath }'` );
+        const content = fs.readFileSync( phpFilepath, 'utf8' );
+        return fromString( content );
 }