Changeset 6216

Timestamp:

10/09/2007 11:16:35 PM (17 years ago)

Author:

markjaquith

Message:

Revert partial prepare() implementation. Needs to be all or nothing. Props xknown. fixes #5145

File:

• trunk/wp-includes/post.php (modified) (4 diffs)

trunk/wp-includes/post.php

@@ -711 +711 @@
         // expected_slashed (everything!)
         $wpdb->query(
-            $wpdb->prepare(
             "UPDATE IGNORE $wpdb->posts SET
             post_author = '$post_author',
@@ -730 +729 @@
             post_modified = '".current_time('mysql')."',
             post_modified_gmt = '".current_time('mysql',1)."',
-            post_parent = %d,
+            post_parent = '$post_parent',
             menu_order = '$menu_order'
-            WHERE ID = %d"
-            , $post_parent, $post_ID ));
+            WHERE ID = $post_ID");
     } else {
         // expected_slashed (everything!)
         $wpdb->query(
-            $wpdb->prepare(
             "INSERT IGNORE INTO $wpdb->posts
             (post_author, post_date, post_date_gmt, post_content, post_content_filtered, post_title, post_excerpt,  post_status, post_type, comment_status, ping_status, post_password, post_name, to_ping, pinged, post_modified, post_modified_gmt, post_parent, menu_order, post_mime_type)
             VALUES
-            ('$post_author', '$post_date', '$post_date_gmt', '$post_content', '$post_content_filtered', '$post_title', '$post_excerpt', '$post_status', '$post_type', '$comment_status', '$ping_status', '$post_password', '$post_name', '$to_ping', '$pinged', '$post_date', '$post_date_gmt', %d, '$menu_order', '$post_mime_type')", $post_parent));
+            ('$post_author', '$post_date', '$post_date_gmt', '$post_content', '$post_content_filtered', '$post_title', '$post_excerpt', '$post_status', '$post_type', '$comment_status', '$ping_status', '$post_password', '$post_name', '$to_ping', '$pinged', '$post_date', '$post_date_gmt', '$post_parent', '$menu_order', '$post_mime_type')");
             $post_ID = (int) $wpdb->insert_id;
     }
@@ -1375 +1372 @@
         // expected_slashed (everything!)
         $wpdb->query(
-            $wpdb->prepare(
             "UPDATE $wpdb->posts SET
             post_author = '$post_author',
@@ -1394 +1390 @@
             post_modified = '".current_time('mysql')."',
             post_modified_gmt = '".current_time('mysql',1)."',
-            post_parent = %d,
+            post_parent = '$post_parent',
             menu_order = '$menu_order',
             post_mime_type = '$post_mime_type',
             guid = '$guid'
-            WHERE ID = %d", $post_parent, $post_ID));
+            WHERE ID = $post_ID");
     } else {
         // expected_slashed (everything!)
         $wpdb->query(
-            $wpdb->prepare(
             "INSERT INTO $wpdb->posts
             (post_author, post_date, post_date_gmt, post_content, post_content_filtered, post_title, post_excerpt,  post_status, post_type, comment_status, ping_status, post_password, post_name, to_ping, pinged, post_modified, post_modified_gmt, post_parent, menu_order, post_mime_type, guid)
             VALUES
-            ('$post_author', '$post_date', '$post_date_gmt', '$post_content', '$post_content_filtered', '$post_title', '$post_excerpt', '$post_status', '$post_type', '$comment_status', '$ping_status', '$post_password', '$post_name', '$to_ping', '$pinged', '$post_date', '$post_date_gmt', %d, '$menu_order', '$post_mime_type', '$guid')", $post_parent ));
+            ('$post_author', '$post_date', '$post_date_gmt', '$post_content', '$post_content_filtered', '$post_title', '$post_excerpt', '$post_status', '$post_type', '$comment_status', '$ping_status', '$post_password', '$post_name', '$to_ping', '$pinged', '$post_date', '$post_date_gmt', '$post_parent', '$menu_order', '$post_mime_type', '$guid')");
             $post_ID = (int) $wpdb->insert_id;
     }