Changeset 62179 for trunk/src/wp-admin/includes/post.php

Timestamp:

03/30/2026 06:01:58 AM (6 months ago)

Author:

westonruter

Message:

Code Quality: Replace void with proper return types in Administration PHPDoc annotations.

Replace void in union return types with null or remove it where the function always returns a value or dies, across 8 files in wp-admin/includes. Adds explicit return null; statements where functions previously fell through without a return value.

Additionally:

• Adds @return never for media_send_to_editor() and removes misleading return from its callers.
• Removes void from return types where the function always returns a value or exits: write_post(), WP_Importer::set_blog(), WP_Importer::set_user().
• Replaces mixed|void with a specific array shape for WP_Site_Health::perform_test().

Developed in ​https://github.com/WordPress/wordpress-develop/pull/11008

Follow-up to r62178, r62177, r61766, r61719.

Props apermo, xate, westonruter, mukesh27, desrosj.
Fixes #64702.

File:

• trunk/src/wp-admin/includes/post.php (modified) (2 diffs)

trunk/src/wp-admin/includes/post.php

@@ -983 +983 @@
  * @since 2.0.0
  *
- * @return int|void Post ID on success, void on failure.
+ * @return int Post ID on success. Dies on failure.
  */
 function write_post() {
@@ -989 +989 @@
         if ( is_wp_error( $result ) ) {
                 wp_die( $result->get_error_message() );
-        } else {
-                return $result;
-        }
+        }
+
+        return $result;
 }