Changeset 62247

Timestamp:

04/20/2026 11:11:32 PM (3 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in get_adjacent_post() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [60733], [61066].

Props sagardeshmukh.
See #64324.

File:

• trunk/tests/phpunit/tests/link/getAdjacentPost.php (modified) (8 diffs)

trunk/tests/phpunit/tests/link/getAdjacentPost.php

@@ -478 +478 @@
         // Should find post_one (previous post that shares term1).
         $this->assertInstanceOf( WP_Post::class, $result );
-        $this->assertEquals( $post1_id, $result->ID );
+        $this->assertSame( $post1_id, $result->ID );
 
         // Test next post.
@@ -485 +485 @@
         // Should find post_three (next post that shares term1).
         $this->assertInstanceOf( WP_Post::class, $result );
-        $this->assertEquals( $post3_id, $result->ID );
+        $this->assertSame( $post3_id, $result->ID );
     }
 
@@ -615 +615 @@
         $previous = get_adjacent_post( false, '', true );
         $this->assertInstanceOf( 'WP_Post', $previous );
-        $this->assertEquals( $post_ids[1], $previous->ID );
+        $this->assertSame( $post_ids[1], $previous->ID );
 
         // Next post should be the 4th post (higher ID, same date).
         $next = get_adjacent_post( false, '', false );
         $this->assertInstanceOf( 'WP_Post', $next );
-        $this->assertEquals( $post_ids[3], $next->ID );
+        $this->assertSame( $post_ids[3], $next->ID );
     }
 
@@ -662 +662 @@
         $previous = get_adjacent_post( false, '', true );
         $this->assertInstanceOf( 'WP_Post', $previous );
-        $this->assertEquals( $post_early, $previous->ID );
+        $this->assertSame( $post_early, $previous->ID );
 
         // Next should be the second identical post (same date, higher ID).
         $next = get_adjacent_post( false, '', false );
         $this->assertInstanceOf( 'WP_Post', $next );
-        $this->assertEquals( $post_ids[1], $next->ID );
+        $this->assertSame( $post_ids[1], $next->ID );
 
         // Test from middle identical post.
@@ -675 +675 @@
         $previous = get_adjacent_post( false, '', true );
         $this->assertInstanceOf( 'WP_Post', $previous );
-        $this->assertEquals( $post_ids[0], $previous->ID );
+        $this->assertSame( $post_ids[0], $previous->ID );
 
         // Next should be the third identical post (same date, higher ID).
         $next = get_adjacent_post( false, '', false );
         $this->assertInstanceOf( 'WP_Post', $next );
-        $this->assertEquals( $post_ids[2], $next->ID );
+        $this->assertSame( $post_ids[2], $next->ID );
 
         // Test from last identical post.
@@ -688 +688 @@
         $previous = get_adjacent_post( false, '', true );
         $this->assertInstanceOf( 'WP_Post', $previous );
-        $this->assertEquals( $post_ids[1], $previous->ID );
+        $this->assertSame( $post_ids[1], $previous->ID );
 
         // Next should be the late post (different date).
         $next = get_adjacent_post( false, '', false );
         $this->assertInstanceOf( 'WP_Post', $next );
-        $this->assertEquals( $post_late, $next->ID );
+        $this->assertSame( $post_late, $next->ID );
     }
 
@@ -720 +720 @@
         // From post 1, next should be post 2.
         $next = get_adjacent_post( false, '', false );
-        $this->assertEquals( $post_ids[1], $next->ID );
+        $this->assertSame( $post_ids[1], $next->ID );
 
         // From post 2, previous should be post 1, next should be post 3.
         $this->go_to( get_permalink( $post_ids[1] ) );
         $previous = get_adjacent_post( false, '', true );
-        $this->assertEquals( $post_ids[0], $previous->ID );
+        $this->assertSame( $post_ids[0], $previous->ID );
         $next = get_adjacent_post( false, '', false );
-        $this->assertEquals( $post_ids[2], $next->ID );
+        $this->assertSame( $post_ids[2], $next->ID );
 
         // From post 3, previous should be post 2, next should be post 4.
         $this->go_to( get_permalink( $post_ids[2] ) );
         $previous = get_adjacent_post( false, '', true );
-        $this->assertEquals( $post_ids[1], $previous->ID );
+        $this->assertSame( $post_ids[1], $previous->ID );
         $next = get_adjacent_post( false, '', false );
-        $this->assertEquals( $post_ids[3], $next->ID );
+        $this->assertSame( $post_ids[3], $next->ID );
 
         // From post 4, previous should be post 3.
         $this->go_to( get_permalink( $post_ids[3] ) );
         $previous = get_adjacent_post( false, '', true );
-        $this->assertEquals( $post_ids[2], $previous->ID );
+        $this->assertSame( $post_ids[2], $previous->ID );
     }
 
@@ -778 +778 @@
         $next = get_adjacent_post( true, '', false, 'category' );
         $this->assertInstanceOf( 'WP_Post', $next );
-        $this->assertEquals( $post_ids[3], $next->ID ); // Post 4 (in category)
+        $this->assertSame( $post_ids[3], $next->ID ); // Post 4 (in category)
     }
 }