Context Navigation

← Previous Change
Next Change →

class-wp-ai-client-prompt-builder.php

Timestamp:

04/22/2026 06:13:47 PM (3 months ago)

Author:

westonruter

Message:

AI: Validate filtered default request timeout in WP_AI_Client_Prompt_Builder.

This checks that the return value of the wp_ai_client_default_request_timeout filter is a non-negative number before passing it to RequestOptions. If the filtered value is invalid, it is discarded in favor of the original default of 30.0 and a _doing_it_wrong() notice is issued. Without this check, a fatal error would ensue from the exception thrown in \WordPress\AiClient\Providers\Http\DTO\RequestOptions::validateTimeout().

The following static analysis issues are addressed:

Use float instead of int for the wp_ai_client_default_request_timeout filter parameter.
Add missing PHP imports for Message and MessagePart in the PHPDoc for wp_ai_client_prompt().
Add PHP return type hints for wp_ai_client_prompt() and WP_AI_Client_Cache::getMultiple().
Use native property type hints in WP_AI_Client_HTTP_Client.

Developed in https://github.com/WordPress/wordpress-develop/pull/11596

Props westonruter, justlevine, flixos90, khushdoms, darshitrajyaguru97, adrmf25, jarodortegaaraya, tusharaddweb, gaurangsondagar.
Fixes #65094.

File:

: 1 edited

trunk/src/wp-includes/ai-client/class-wp-ai-client-prompt-builder.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/ai-client/class-wp-ai-client-prompt-builder.php

-              r62101
+              r62255
+                }
+                $default_timeout = 30.0;
                 /**
                  * Filters the default request timeout in seconds for AI Client HTTP requests.
 …
                  * @since 7.0.0
+                 *
                  * @param int $default_timeout The default timeout in seconds.
+                 * @param float $default_timeout The default timeout in seconds.
                  */
+                $default_timeout = (int) apply_filters( 'wp_ai_client_default_request_timeout', 30 );
+                $filtered_default_timeout = apply_filters( 'wp_ai_client_default_request_timeout', $default_timeout );
+                if ( is_numeric( $filtered_default_timeout ) && (float) $filtered_default_timeout >= 0.0 ) {
+                        $default_timeout = (float) $filtered_default_timeout;
+                } else {
+                        _doing_it_wrong(
+                                __METHOD__,
+                                sprintf(
+                                        /* translators: %s: wp_ai_client_default_request_timeout */
+                                        __( 'The %s filter must return a non-negative number.' ),
+                                        '<code>wp_ai_client_default_request_timeout</code>'
+                                ),
+                                '7.0.0'
+                        );
+                }
                 $this->builder->usingRequestOptions(

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 62255 for trunk/src/wp-includes/ai-client/class-wp-ai-client-prompt-builder.php

Legend:

trunk/src/wp-includes/ai-client/class-wp-ai-client-prompt-builder.php

Download in other formats: