Changeset 62288 for trunk/src/wp-includes/class-wp-connector-registry.php

Timestamp:

04/30/2026 12:16:22 PM (4 months ago)

Author:

jorgefilipecosta

Message:

Connectors: Add is_active callback support to plugin registration.

Adds an optional is_active callable to the plugin definition accepted by
WP_Connector_Registry::register(). The callback receives no arguments, must
return a boolean, and is used by the Connectors screen to decide whether a
connector's backing plugin is currently active. When omitted, it defaults to
__return_true; when provided but not callable, registration fails with a
_doing_it_wrong() notice.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/11565

Props iamadisingh, jorgefilipecosta, mukesh27, gziolo.
Fixes #65020.

File:

• trunk/src/wp-includes/class-wp-connector-registry.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-connector-registry.php

@@ -41 +41 @@
  *     },
  *     plugin?: array{
- *         file: non-empty-string
+ *         file: non-empty-string,
+ *         is_active?: callable(): bool
  *     }
  * }
@@ -110 +111 @@
          *         Optional. Plugin data for install/activate UI.
          *
-         *         @type string $file The plugin's main file path relative to the plugins
-         *                            directory (e.g. 'my-plugin/my-plugin.php' or 'hello.php').
+         *         @type string   $file      Optional. The plugin's main file path relative to the
+         *                                   plugins directory (e.g. 'my-plugin/my-plugin.php' or
+         *                                   'hello.php').
+         *         @type callable $is_active Optional callback to determine whether the plugin
+         *                                   is active. Receives no arguments and must return bool.
+         *                                   Defaults to `__return_true`.
          *     }
          * }
@@ -244 +249 @@
                 }
 
-                if ( ! empty( $args['plugin'] ) && is_array( $args['plugin'] ) && ! empty( $args['plugin']['file'] ) ) {
-                        $connector['plugin'] = array( 'file' => $args['plugin']['file'] );
+                $connector['plugin'] = array();
+
+                if ( ! empty( $args['plugin'] ) && is_array( $args['plugin'] ) ) {
+                        if ( ! empty( $args['plugin']['file'] ) ) {
+                                $connector['plugin']['file'] = $args['plugin']['file'];
+                        }
+
+                        if ( isset( $args['plugin']['is_active'] ) ) {
+                                if ( ! is_callable( $args['plugin']['is_active'] ) ) {
+                                        _doing_it_wrong(
+                                                __METHOD__,
+                                                /* translators: %s: Connector ID. */
+                                                sprintf( __( 'Connector "%s" plugin is_active must be callable.' ), esc_html( $id ) ),
+                                                '7.0.0'
+                                        );
+                                        return null;
+                                }
+
+                                $connector['plugin']['is_active'] = $args['plugin']['is_active'];
+                        }
+                }
+
+                if ( ! isset( $connector['plugin']['is_active'] ) ) {
+                        $connector['plugin']['is_active'] = '__return_true';
                 }