Changeset 62288 for trunk/tests/phpunit/tests/connectors/wpConnectorRegistry.php

Timestamp:

04/30/2026 12:16:22 PM (3 months ago)

Author:

jorgefilipecosta

Message:

Connectors: Add is_active callback support to plugin registration.

Adds an optional is_active callable to the plugin definition accepted by
WP_Connector_Registry::register(). The callback receives no arguments, must
return a boolean, and is used by the Connectors screen to decide whether a
connector's backing plugin is currently active. When omitted, it defaults to
__return_true; when provided but not callable, registration fails with a
_doing_it_wrong() notice.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/11565

Props iamadisingh, jorgefilipecosta, mukesh27, gziolo.
Fixes #65020.

File:

• trunk/tests/phpunit/tests/connectors/wpConnectorRegistry.php (modified) (1 diff)

trunk/tests/phpunit/tests/connectors/wpConnectorRegistry.php

@@ -300 +300 @@
 
                 $this->assertArrayHasKey( 'plugin', $result );
-                $this->assertSame( array( 'file' => 'my-plugin/my-plugin.php' ), $result['plugin'] );
-        }
-
-        /**
-         * @ticket 64791
-         */
-        public function test_register_omits_plugin_when_not_provided() {
+                $this->assertSame( 'my-plugin/my-plugin.php', $result['plugin']['file'] );
+        }
+
+        /**
+         * @ticket 65020
+         */
+        public function test_register_stores_plugin_is_active_callback() {
+                $args           = self::$default_args;
+                $args['plugin'] = array(
+                        'file'      => 'my-plugin/my-plugin.php',
+                        'is_active' => '__return_true',
+                );
+
+                $result = $this->registry->register( 'with-callback', $args );
+
+                $this->assertIsArray( $result );
+                $this->assertArrayHasKey( 'is_active', $result['plugin'] );
+                $this->assertIsCallable( $result['plugin']['is_active'] );
+        }
+
+        /**
+         * @ticket 65020
+         */
+        public function test_register_rejects_non_callable_plugin_is_active() {
+                $this->setExpectedIncorrectUsage( 'WP_Connector_Registry::register' );
+
+                $args           = self::$default_args;
+                $args['plugin'] = array(
+                        'file'      => 'my-plugin/my-plugin.php',
+                        'is_active' => 'not_a_real_function_name',
+                );
+
+                $result = $this->registry->register( 'bad-callback', $args );
+
+                $this->assertNull( $result );
+        }
+
+        /**
+         * @ticket 65020
+         */
+        public function test_register_defaults_plugin_is_active_to_return_true() {
+                $args           = self::$default_args;
+                $args['plugin'] = array( 'file' => 'my-plugin/my-plugin.php' );
+
+                $result = $this->registry->register( 'default-callback', $args );
+
+                $this->assertIsArray( $result );
+                $this->assertArrayHasKey( 'is_active', $result['plugin'] );
+                $this->assertSame( '__return_true', $result['plugin']['is_active'] );
+        }
+
+        /**
+         * @ticket 64791
+         */
+        public function test_register_defaults_plugin_when_not_provided() {
                 $result = $this->registry->register( 'no-plugin', self::$default_args );
 
-                $this->assertArrayNotHasKey( 'plugin', $result );
+                $this->assertArrayHasKey( 'plugin', $result );
+                $this->assertArrayNotHasKey( 'file', $result['plugin'] );
+                $this->assertSame( '__return_true', $result['plugin']['is_active'] );
         }