Changeset 62289

Timestamp:

04/30/2026 02:05:06 PM (7 weeks ago)

Author:

jorgefilipecosta

Message:

Connectors: Gate default setting auto-registration on is_active.

Update _wp_register_default_connector_settings() to register a connector's
default API key setting only when the connector's plugin.is_active callback
returns true.
Add tests covering the gate's branches: setting skipped when is_active
returns false, setting registered when it returns true.

Props jorgefilipecosta, gziolo, peterwilsoncc.
Fixes #65099.

Location:

trunk

Files:

• src/wp-includes/connectors.php (modified) (2 diffs)
• tests/phpunit/tests/connectors/wpRegisterDefaultConnectorSettings.php (added)

trunk/src/wp-includes/connectors.php

@@ -550 +550 @@
  */
 function _wp_register_default_connector_settings(): void {
-    $ai_registry         = AiClient::defaultRegistry();
     $registered_settings = get_registered_settings();
 
-    foreach ( wp_get_connectors() as $connector_id => $connector_data ) {
+    foreach ( wp_get_connectors() as $connector_data ) {
         $auth = $connector_data['authentication'];
         if ( 'api_key' !== $auth['method'] || empty( $auth['setting_name'] ) ) {
@@ -564 +563 @@
         }
 
-        // For AI providers, skip if the provider is not in the AI Client registry.
-        if ( 'ai_provider' === $connector_data['type'] && ! $ai_registry->hasProvider( $connector_id ) ) {
+        if ( ! isset( $connector_data['plugin']['is_active'] ) || ! is_callable( $connector_data['plugin']['is_active'] ) ) {
+            continue;
+        }
+
+        if ( ! call_user_func( $connector_data['plugin']['is_active'] ) ) {
             continue;
         }