Context Navigation

← Previous Change
Next Change →

l10n.php

Timestamp:

05/07/2026 09:22:08 PM (2 months ago)

Author:

jorbin

Message:

I18N: Harden against undefined index in _load_script_textdomain_from_src().

This guards against an undefined index warning being raised when a script or script module is registered with a URL that lacks a path component.

This also adds full PHPStan type definitions for wp_parse_url(), ensuring that the _load_script_textdomain_from_src() function has no PHPStan errors at rule level 10.

Developed in https://github.com/WordPress/wordpress-develop/pull/11690

Follow-up to r62278.

Reviewed by desrosj, jorbin.
Merges [62293] to the 7.0 branch.

Props westonruter, manzoorwanijk, mukesh27.
See #65015, #64238.

Location:

branches/7.0

Files:

: 2 edited

. (modified) (1 prop)
src/wp-includes/l10n.php (modified) (4 diffs)

Legend:

: Unmodified
: Added
: Removed

branches/7.0
- Property svn:mergeinfo changed
  /trunk merged: 62293

branches/7.0/src/wp-includes/l10n.php

-              r62286
+              r62325
  */
 function _load_script_textdomain_from_src( string $handle, string $src, string $domain, string $path, bool $is_module ) {
+        /** @var WP_Textdomain_Registry $wp_textdomain_registry */
         global $wp_textdomain_registry;
 …
+        }
+        $path = untrailingslashit( $path );
+        if ( $path ) {
+                $path = untrailingslashit( $path );
+        }
         // If a path was given and the handle file exists simply return it.
 …
         $languages_path = WP_LANG_DIR;
+        $src_url     = wp_parse_url( $src );
+        $src_url = wp_parse_url( $src );
+        if ( ! $src_url ) {
+                return load_script_translations( false, $handle, $domain );
+        }
+        $src_url['path'] ??= '';
         $content_url = wp_parse_url( content_url() );
+        if ( ! $content_url ) {
+                return load_script_translations( false, $handle, $domain );
+        }
         $plugins_url = wp_parse_url( plugins_url() );
         $site_url    = wp_parse_url( site_url() );
 …
         // If the source is not from WP.
         if ( false === $relative ) {
+        if ( ! is_string( $relative ) ) {
                 return load_script_translations( false, $handle, $domain );
+        }

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 62325 for branches/7.0/src/wp-includes/l10n.php

Legend:

branches/7.0

branches/7.0/src/wp-includes/l10n.php

Download in other formats: