Context Navigation

← Previous Change
Next Change →

wpStyleLoaderSrc.php

Timestamp:

05/13/2026 03:28:14 AM (2 months ago)

Author:

audrasjb

Message:

Toolbar: Revert add CSS from admin color scheme on front-end.

The implementation issues a server-side HTTP request on every front-end page load and extracts the toolbar CSS via fragile substring matching. Alternatives are too large to land this late in the release cycle, so the fix is deferred to a future release.

Reverts [62025].

Reviewed by audrasjb, wildworks.
Merges [62349] to the 7.0 branch.
Props desrosj, jorbin, mukesh27, sabernhardt, wildworks.
See #64762.

Location:

branches/7.0

Files:

: 2 edited

. (modified) (1 prop)
tests/phpunit/tests/dependencies/wpStyleLoaderSrc.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

branches/7.0
- Property svn:mergeinfo changed
  /trunk merged: 62349

branches/7.0/tests/phpunit/tests/dependencies/wpStyleLoaderSrc.php

-              r62025
+              r62354
         /**
          * Tests that PHP warnings are not thrown when wp_style_loader_src() is called
          * before the `$_wp_admin_css_colors` global is set within the admin.
+         * before the `$_wp_admin_css_colors` global is set.
+         *
          * The warnings that we should not see:
 …
+         *
          * @ticket 61302
-         * @ticket 64762
          */
         public function test_without_wp_admin_css_colors_global() {
+                if ( is_admin() ) {
+                        $this->assertFalse( wp_style_loader_src( '', 'colors' ) );
+                } else {
+                        $this->assertStringContainsString( '/colors.css', wp_style_loader_src( '', 'colors' ) );
+                }
+                $this->assertFalse( wp_style_loader_src( '', 'colors' ) );
+        }
+}

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 62354 for branches/7.0/tests/phpunit/tests/dependencies/wpStyleLoaderSrc.php

Legend:

branches/7.0

branches/7.0/tests/phpunit/tests/dependencies/wpStyleLoaderSrc.php

Download in other formats: