Changeset 62408 for trunk/src/wp-includes/class-wp-widget-factory.php

Timestamp:

05/22/2026 06:59:15 AM (4 months ago)

Author:

westonruter

Message:

Plugins: Improve hook performance by using spl_object_id() instead of spl_object_hash() to construct unique IDs.

• Also use spl_object_id() similarly when registering and unregistering classic widgets.
• Improve typing and phpdoc in _wp_filter_build_unique_id(). Return null for malformed callbacks.
• Add tests for _wp_filter_build_unique_id().
• Improve type safety of WP_Hook::add_filter() in case an invalid callback is provided for parity with ::has_filter() and ::remove_filter().

Developed in ​https://github.com/WordPress/wordpress-develop/pull/11865
Follow-up to r46220, r46801, r60179.

Props bor0, westonruter, SergeyBiryukov, schlessera, arshidkv12, knutsp, spacedmonkey, swissspidy.
See #64898.
Fixes #58291.

File:

• trunk/src/wp-includes/class-wp-widget-factory.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-widget-factory.php

@@ -58 +58 @@
         public function register( $widget ) {
                 if ( $widget instanceof WP_Widget ) {
-                        $this->widgets[ spl_object_hash( $widget ) ] = $widget;
+                        $this->widgets[ spl_object_id( $widget ) ] = $widget;
                 } else {
                         $this->widgets[ $widget ] = new $widget();
@@ -75 +75 @@
         public function unregister( $widget ) {
                 if ( $widget instanceof WP_Widget ) {
-                        unset( $this->widgets[ spl_object_hash( $widget ) ] );
+                        unset( $this->widgets[ spl_object_id( $widget ) ] );
                 } else {
                         unset( $this->widgets[ $widget ] );