Changeset 62482 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

06/10/2026 03:04:54 PM (2 months ago)

Author:

dmsnell

Message:

General: Add support for unicode email addresses in is_email and sanitize_email

This adds support for the unicode address extensions in RFC 6530-3 and refactors the code so there are fewer long regexes and less duplication between sanitize_email and is_email. A new class, WP_Email_Address, provides the shared parts.

Opting out of unicode support is easy, default-filters.php adds unicode support by adding filters, which can be removed.

sanitize_email no longer does major changes like removing an entire subdomain from someone's address, it only cleans up things like soft hyphens and whitespace — changes that happen when coping an email address from text.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/5237
Discussed in: https://core.trac.wordpress.org/ticket/31992

Props agulbra, akirk, benniledl, dmsnell, ironprogrammer, justlevine, mdawaffe, mukeshpanchal27, SirLouen, tusharbharti.
Fixes #31992.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -2322 +2322 @@
                         'post'         => self::$post_id,
                         'author_name'  => 'Bleeding Gums Murphy',
-                        'author_email' => 'murphy@' . rand_long_str( 190 ) . '.com',
+                        'author_email' => 'murphy@' . rand_long_str( 60 ) . '.' . rand_long_str( 60 ) . '.com',
                         'author_url'   => 'http://jazz.gingivitis.com',
                         'content'      => 'This isn\'t a saxophone. It\'s an umbrella.',
@@ -2955 +2955 @@
 
                 $params = array(
-                        'author_email' => 'murphy@' . rand_long_str( 190 ) . '.com',
+                        'author_email' => 'murphy@' . rand_long_str( 60 ) . '.' . rand_long_str( 60 ) . '.com',
                         'content'      => 'This isn\'t a saxophone. It\'s an umbrella.',
                 );