Changeset 62517

Timestamp:

06/17/2026 11:34:55 AM (3 months ago)

Author:

SergeyBiryukov

Message:

Media: Make ::update_size() parameters consistent across image editors.

Includes:

• Standardizing default values on null vs. false.
• Updating the documentation to correct parameter types.
• Adding missing parameter descriptions.

Follow-up to [22094].

Props Soean, mukesh27, SergeyBiryukov.
See #64897.

Location:

trunk/src/wp-includes

Files:

• class-wp-image-editor-gd.php (modified) (1 diff)
• class-wp-image-editor-imagick.php (modified) (1 diff)
• class-wp-image-editor.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-image-editor-gd.php

@@ -145 +145 @@
          * @since 3.5.0
          *
-         * @param int $width
-         * @param int $height
+         * @param int|null $width  Image width.
+         * @param int|null $height Image height.
          * @return true
          */
-        protected function update_size( $width = false, $height = false ) {
+        protected function update_size( $width = null, $height = null ) {
                 if ( ! $width ) {
                         $width = imagesx( $this->image );

trunk/src/wp-includes/class-wp-image-editor-imagick.php

@@ -248 +248 @@
          * @since 3.5.0
          *
-         * @param int $width
-         * @param int $height
+         * @param int|null $width  Image width.
+         * @param int|null $height Image height.
          * @return true|WP_Error
          */
         protected function update_size( $width = null, $height = null ) {
                 $size = null;
+
                 if ( ! $width || ! $height ) {
                         try {

trunk/src/wp-includes/class-wp-image-editor.php

@@ -202 +202 @@
          * @since 3.5.0
          *
-         * @param int $width
-         * @param int $height
+         * @param int|null $width  Image width.
+         * @param int|null $height Image height.
          * @return true
          */