Changeset 62555

Timestamp:

06/25/2026 07:57:55 AM (3 months ago)

Author:

gziolo

Message:

AI Client: Skip non-ability function calls in execute_abilities()

WP_AI_Client_Ability_Function_Resolver::execute_abilities() should only respond to function calls that are ability calls. Previously, non-ability tool calls were passed to execute_ability() and received an invalid_ability_call response, preventing other tool handlers from processing them.

This updates execute_abilities() to mirror has_ability_calls() by checking is_ability_call() before executing, and adds regression coverage for mixed ability and non-ability calls.

Props khokansardar, jigar-bhanushali.
Fixes #65504.

Location:

trunk

Files:

• src/wp-includes/ai-client/class-wp-ai-client-ability-function-resolver.php (modified) (1 diff)
• tests/phpunit/tests/ai-client/wpAiClientAbilityFunctionResolver.php (modified) (1 diff)

trunk/src/wp-includes/ai-client/class-wp-ai-client-ability-function-resolver.php

@@ -191 +191 @@
                         if ( $part->getType()->isFunctionCall() ) {
                                 $function_call = $part->getFunctionCall();
-                                if ( $function_call instanceof FunctionCall ) {
+                                if ( $function_call instanceof FunctionCall && $this->is_ability_call( $function_call ) ) {
                                         $function_response = $this->execute_ability( $function_call );
                                         $response_parts[]  = new MessagePart( $function_response );

trunk/tests/phpunit/tests/ai-client/wpAiClientAbilityFunctionResolver.php

@@ -668 +668 @@
 
         /**
+         * Test execute_abilities ignores non-ability function calls.
+         *
+         * A message may contain function calls for tools handled elsewhere (not
+         * prefixed with `wpab__`). Those must be left untouched rather than answered
+         * with a spurious `invalid_ability_call` error response, matching the parts
+         * that has_ability_calls() reports.
+         *
+         * @ticket 65504
+         */
+        public function test_execute_abilities_ignores_non_ability_function_calls() {
+                $resolver = new WP_AI_Client_Ability_Function_Resolver( 'wpaiclienttests/simple' );
+
+                $ability_call = new FunctionCall(
+                        'call-ability',
+                        'wpab__wpaiclienttests__simple',
+                        array()
+                );
+
+                $other_call = new FunctionCall(
+                        'call-other',
+                        'some_other_tool',
+                        array()
+                );
+
+                $message = new ModelMessage(
+                        array(
+                                new MessagePart( $ability_call ),
+                                new MessagePart( $other_call ),
+                        )
+                );
+
+                $result = $resolver->execute_abilities( $message );
+
+                $this->assertInstanceOf( UserMessage::class, $result );
+                $parts = $result->getParts();
+                // Only the ability call should produce a response; the other tool is left alone.
+                $this->assertCount( 1, $parts );
+
+                $response = $parts[0]->getFunctionResponse();
+                $this->assertInstanceOf( FunctionResponse::class, $response );
+                $this->assertSame( 'wpab__wpaiclienttests__simple', $response->getName() );
+                $data = $response->getResponse();
+                $this->assertArrayNotHasKey( 'code', $data );
+                $this->assertArrayHasKey( 'success', $data );
+                $this->assertTrue( $data['success'] );
+        }
+
+        /**
          * Test execute_abilities with ability that has parameters.
          *