Changeset 62564

Timestamp:

06/25/2026 07:43:05 PM (10 hours ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use array_any() in WP_REST_Comments_Controller.

This commit replaces a foreach loop in ::check_post_type_supports_notes() that iterates the editor supports, returns true as soon as an element has non-empty notes, and otherwise falls through to false. That is exactly what PHP 8.4's array_any() expresses in a single, more readable call.

WordPress core includes a polyfill for array_any() on PHP < 8.4 as of WordPress 6.8, so the change works on every supported PHP version without raising the minimum requirement.

Follow-up to [59783], [62550], [62553].

Props Soean.
See #65519.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -2050 +2050 @@
     private function check_post_type_supports_notes( $post_type ) {
         $supports = get_all_post_type_supports( $post_type );
+
         if ( ! isset( $supports['editor'] ) ) {
             return false;
         }
+
         if ( ! is_array( $supports['editor'] ) ) {
             return false;
         }
-        foreach ( $supports['editor'] as $item ) {
-            if ( ! empty( $item['notes'] ) ) {
-                return true;
-            }
-        }
-        return false;
+
+        return array_any( $supports['editor'], fn( $item ) => ! empty( $item['notes'] ) );
     }
 }