Changeset 62593

Timestamp:

06/30/2026 04:36:25 PM (3 months ago)

Author:

SergeyBiryukov

Message:

Tests: Move the HTTP response codes test for consistency.

While the test was originally written to verify that the WP_Http class has all the HTTP response codes as constants, it ensures that the constants match the response codes stored in the $wp_header_to_desc global used by the get_status_header_desc() function, so the latter's unit test file appears to be the logical placement.

Follow-up to [36749], [46107].

Props pbearne, khokansardar, SergeyBiryukov.
Fixes #65527.

Location:

trunk/tests/phpunit/tests

Files:

• functions/getStatusHeaderDesc.php (modified) (1 diff)
• http/http.php (modified) (1 diff)

trunk/tests/phpunit/tests/functions/getStatusHeaderDesc.php

@@ -42 +42 @@
                 );
         }
+
+        /**
+         * Tests that the HTTP response codes stored in the `$wp_header_to_desc` global
+         * match the constants in the WP_Http class.
+         *
+         * @ticket 35426
+         */
+        public function test_http_response_code_constants() {
+                global $wp_header_to_desc;
+
+                $ref       = new ReflectionClass( 'WP_Http' );
+                $constants = $ref->getConstants();
+
+                // This primes the `$wp_header_to_desc` global:
+                get_status_header_desc( 200 );
+
+                $this->assertSame( array_keys( $wp_header_to_desc ), array_values( $constants ) );
+        }
 }

trunk/tests/phpunit/tests/http/http.php

@@ -276 +276 @@
                         array( 123, PHP_URL_PATH, '123' ),
                 );
-        }
-
-        /**
-         * @ticket 35426
-         *
-         * @covers ::get_status_header_desc
-         */
-        public function test_http_response_code_constants() {
-                global $wp_header_to_desc;
-
-                $ref       = new ReflectionClass( 'WP_Http' );
-                $constants = $ref->getConstants();
-
-                // This primes the `$wp_header_to_desc` global:
-                get_status_header_desc( 200 );
-
-                $this->assertSame( array_keys( $wp_header_to_desc ), array_values( $constants ) );
         }