Changeset 62685

Timestamp:

07/10/2026 12:03:55 PM (5 weeks ago)

Author:

tyxla

Message:

Administration: Show part of the excerpt for untitled posts in the list table Compact view.

Posts and pages with no title previously displayed only "(no title)" in the
posts list table, making untitled items hard to tell apart. When a post has no
title, this appends up to 15 words of its trimmed excerpt after the title link
in the Compact (list) view.

The excerpt is only shown when the Excerpt view is not active, the post has no
title, no password is required, and the current user can read the post. The
checkbox and locked-post accessibility labels are updated to match the visible
link text, and optional styling is added for the trimmed excerpt.

Props sabernhardt, mcsf, tyxla, annezazu, ramonopoly, joen, wildworks, joedolson, jeffpaul, matt.

Fixes #65022.

Location:

trunk

Files:

• src/wp-admin/css/list-tables.css (modified) (1 diff)
• src/wp-admin/includes/class-wp-posts-list-table.php (modified) (6 diffs)
• tests/phpunit/tests/admin/wpPostsListTable.php (modified) (1 diff)

trunk/src/wp-admin/css/list-tables.css

@@ -364 +364 @@
 }
 
+.trimmed-post-excerpt {
+        font-weight: 400;
+}
+
 /* Media file column */
 table.media .column-title .media-icon {

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1014 +1014 @@
 
         /**
+         * Gets a trimmed excerpt to display in place of a missing post title.
+         *
+         * Only returns text in the Compact list view for posts that have no title,
+         * do not require a password, and that the current user is allowed to read.
+         *
+         * @since 7.1.0
+         *
+         * @global string $mode List table view mode.
+         *
+         * @param WP_Post $post The current WP_Post object.
+         * @return string The escaped, trimmed excerpt, or an empty string.
+         */
+        protected function get_no_title_excerpt( $post ) {
+                global $mode;
+
+                if ( 'excerpt' === $mode
+                        || '' !== get_the_title( $post )
+                        || post_password_required( $post )
+                        || ! current_user_can( 'read_post', $post->ID )
+                ) {
+                        return '';
+                }
+
+                $excerpt = get_the_excerpt( $post );
+
+                if ( '' === $excerpt || ! is_string( $excerpt ) ) {
+                        return '';
+                }
+
+                return esc_html( wp_trim_words( $excerpt, 15 ) );
+        }
+
+        /**
          * Handles the checkbox column output.
          *
          * @since 4.3.0
          * @since 5.9.0 Renamed `$post` to `$item` to match parent class for PHP 8 named parameter support.
+         * @since 7.1.0 Includes a trimmed excerpt for untitled posts in Compact view.
          *
          * @param WP_Post $item The current WP_Post object.
@@ -1038 +1072 @@
                  */
                 if ( apply_filters( 'wp_list_table_show_post_checkbox', $show, $post ) ) :
+
+                        $post_title = _draft_or_post_title();
+
+                        // If the post has no title, try adding part of the excerpt.
+                        $no_title_excerpt = $this->get_no_title_excerpt( $post );
+                        if ( '' !== $no_title_excerpt ) {
+                                $post_title .= ' ' . $no_title_excerpt;
+                        }
                         ?>
                         <input id="cb-select-<?php the_ID(); ?>" type="checkbox" name="post[]" value="<?php the_ID(); ?>" />
@@ -1044 +1086 @@
                                 <?php
                                         /* translators: %s: Post title. */
-                                        printf( __( 'Select %s' ), _draft_or_post_title() );
+                                        printf( __( 'Select %s' ), $post_title );
                                 ?>
                                 </span>
@@ -1055 +1097 @@
                                         /* translators: Hidden accessibility text. %s: Post title. */
                                         __( '&#8220;%s&#8221; is locked' ),
-                                        _draft_or_post_title()
+                                        $post_title
                                 );
                                 ?>
@@ -1083 +1125 @@
          *
          * @since 4.3.0
+         * @since 7.1.0 Includes a trimmed excerpt for untitled posts in Compact view.
          *
          * @global string $mode List table view mode.
@@ -1136 +1179 @@
 
                 $title = _draft_or_post_title();
+
+                // If the post has no title, try adding part of the excerpt.
+                $no_title_excerpt = $this->get_no_title_excerpt( $post );
+                if ( '' !== $no_title_excerpt ) {
+                        $title .= ' <span class="trimmed-post-excerpt">' . $no_title_excerpt . '</span>';
+                }
 
                 if ( $can_edit_post && 'trash' !== $post->post_status ) {

trunk/tests/phpunit/tests/admin/wpPostsListTable.php

@@ -331 +331 @@
                 $this->assertSame( $expected, $actual );
         }
+
+        /**
+         * Renders the title column for a post in a given list view mode.
+         *
+         * @param WP_Post $post       The post to render.
+         * @param string  $mode_value The list view mode ('list' or 'excerpt').
+         * @return string The rendered output.
+         */
+        protected function render_column_title( $post, $mode_value ) {
+                global $mode;
+                $mode = $mode_value;
+
+                $table = _get_list_table( 'WP_Posts_List_Table', array( 'screen' => 'edit-post' ) );
+                $table->set_hierarchical_display( false );
+
+                ob_start();
+                $table->column_title( $post );
+                return ob_get_clean();
+        }
+
+        /**
+         * @ticket 65022
+         *
+         * @dataProvider data_no_title_excerpt_visibility
+         *
+         * @covers WP_Posts_List_Table::column_title
+         * @covers WP_Posts_List_Table::get_no_title_excerpt
+         *
+         * @param string $mode_value  The list view mode ('list' or 'excerpt').
+         * @param array  $post_args   Overrides for the post to create.
+         * @param bool   $should_show Whether the trimmed excerpt should be shown.
+         */
+        public function test_no_title_excerpt_visibility( $mode_value, $post_args, $should_show ) {
+                wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
+
+                $post = self::factory()->post->create_and_get(
+                        array_merge(
+                                array(
+                                        'post_type'    => 'post',
+                                        'post_status'  => 'publish',
+                                        'post_title'   => '',
+                                        'post_excerpt' => 'Alpha beta gamma delta epsilon.',
+                                ),
+                                $post_args
+                        )
+                );
+
+                $output = $this->render_column_title( $post, $mode_value );
+
+                if ( $should_show ) {
+                        $this->assertStringContainsString( 'class="trimmed-post-excerpt"', $output );
+                } else {
+                        $this->assertStringNotContainsString( 'class="trimmed-post-excerpt"', $output );
+                }
+        }
+
+        /**
+         * Data provider.
+         *
+         * @return array[]
+         */
+        public function data_no_title_excerpt_visibility() {
+                return array(
+                        'compact view, untitled'  => array( 'list', array(), true ),
+                        'extended view, untitled' => array( 'excerpt', array(), false ),
+                        'compact view, has title' => array( 'list', array( 'post_title' => 'A real title' ), false ),
+                        'compact view, password'  => array( 'list', array( 'post_password' => 'secret' ), false ),
+                );
+        }
+
+        /**
+         * @ticket 65022
+         *
+         * @covers WP_Posts_List_Table::column_title
+         * @covers WP_Posts_List_Table::get_no_title_excerpt
+         */
+        public function test_no_title_excerpt_is_trimmed_to_15_words() {
+                wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
+
+                $words = array();
+                for ( $n = 1; $n <= 20; $n++ ) {
+                        $words[] = 'word' . $n;
+                }
+
+                $post = self::factory()->post->create_and_get(
+                        array(
+                                'post_title'   => '',
+                                'post_excerpt' => implode( ' ', $words ),
+                                'post_status'  => 'publish',
+                        )
+                );
+
+                $output = $this->render_column_title( $post, 'list' );
+
+                $this->assertStringContainsString( 'word15', $output, 'The 15th word should be present.' );
+                $this->assertStringNotContainsString( 'word16', $output, 'The 16th word should be trimmed.' );
+                $this->assertStringContainsString( '&hellip;', $output, 'The excerpt should end with an ellipsis.' );
+        }
+
+        /**
+         * Ensures excerpt output is escaped, including markup reintroduced by the `wp_trim_words` filter.
+         *
+         * @ticket 65022
+         *
+         * @covers WP_Posts_List_Table::column_title
+         * @covers WP_Posts_List_Table::get_no_title_excerpt
+         */
+        public function test_no_title_excerpt_is_escaped() {
+                wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
+
+                $post = self::factory()->post->create_and_get(
+                        array(
+                                'post_title'   => '',
+                                'post_excerpt' => 'Some excerpt text.',
+                                'post_status'  => 'publish',
+                        )
+                );
+
+                add_filter( 'wp_trim_words', array( $this, 'filter_wp_trim_words_return_markup' ) );
+                $output = $this->render_column_title( $post, 'list' );
+                remove_filter( 'wp_trim_words', array( $this, 'filter_wp_trim_words_return_markup' ) );
+
+                $this->assertStringContainsString( '&lt;script&gt;alert(1)&lt;/script&gt;', $output, 'The markup should be escaped.' );
+                $this->assertStringNotContainsString( '<script>alert(1)</script>', $output, 'Raw markup should not be output.' );
+        }
+
+        /**
+         * Filter callback returning markup for the `wp_trim_words` filter.
+         *
+         * @return string
+         */
+        public function filter_wp_trim_words_return_markup() {
+                return '<script>alert(1)</script>';
+        }
+
+        /**
+         * @ticket 65022
+         *
+         * @covers WP_Posts_List_Table::get_no_title_excerpt
+         */
+        public function test_no_title_excerpt_hidden_when_user_cannot_read_post() {
+                $author = self::factory()->user->create( array( 'role' => 'administrator' ) );
+
+                $post = self::factory()->post->create_and_get(
+                        array(
+                                'post_author'  => $author,
+                                'post_title'   => '',
+                                'post_excerpt' => 'Private draft excerpt.',
+                                'post_status'  => 'draft',
+                        )
+                );
+
+                // A subscriber cannot read another user's draft.
+                wp_set_current_user( self::factory()->user->create( array( 'role' => 'subscriber' ) ) );
+
+                $output = $this->render_column_title( $post, 'list' );
+
+                $this->assertStringNotContainsString( 'class="trimmed-post-excerpt"', $output );
+        }
+
+        /**
+         * @ticket 65022
+         *
+         * @covers WP_Posts_List_Table::column_cb
+         * @covers WP_Posts_List_Table::get_no_title_excerpt
+         */
+        public function test_checkbox_label_includes_no_title_excerpt() {
+                wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
+
+                global $mode;
+                $mode = 'list';
+
+                $post = self::factory()->post->create_and_get(
+                        array(
+                                'post_title'   => '',
+                                'post_excerpt' => 'Hello world example excerpt.',
+                                'post_status'  => 'publish',
+                        )
+                );
+
+                $GLOBALS['post'] = $post;
+
+                $table = _get_list_table( 'WP_Posts_List_Table', array( 'screen' => 'edit-post' ) );
+
+                ob_start();
+                $table->column_cb( $post );
+                $output = ob_get_clean();
+
+                $this->assertStringContainsString( 'Select (no title) Hello world example excerpt.', $output );
+        }
 }