Changeset 62699

Timestamp:

07/12/2026 11:19:36 PM (2 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use in_array() instead of array_search() for existence checks.

Several places in core use array_search() purely to determine whether a value exists in an array, comparing the result against false. In these cases the returned key/position is never used, so in_array() expresses the intent more clearly and avoids computing a return value that is discarded.

This commit replaces those existence-only array_search() calls with in_array(). The strict (true) comparison flag is preserved in every case, so there is no change in behavior.

Props Soean.
See #64897.

Location:

trunk

Files:

• src/wp-admin/nav-menus.php (modified) (1 diff)
• src/wp-includes/kses.php (modified) (1 diff)
• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/includes/object-cache.php (modified) (1 diff)

trunk/src/wp-admin/nav-menus.php

@@ -1180 +1180 @@
                                                                         if ( ! isset( $auto_add['auto_add'] ) ) {
                                                                                 $auto_add = false;
-                                                                        } elseif ( false !== array_search( $nav_menu_selected_id, $auto_add['auto_add'], true ) ) {
+                                                                        } elseif ( in_array( $nav_menu_selected_id, $auto_add['auto_add'], true ) ) {
                                                                                 $auto_add = true;
                                                                         } else {

trunk/src/wp-includes/kses.php

@@ -1864 +1864 @@
                          */
 
-                        if ( false === array_search( strtolower( $value ), $checkvalue, true ) ) {
+                        if ( ! in_array( strtolower( $value ), $checkvalue, true ) ) {
                                 $ok = false;
                         }

trunk/src/wp-includes/post.php

@@ -3737 +3737 @@
                         foreach ( (array) $real_mime_types as $real ) {
                                 if ( preg_match( "#$pattern#", $real )
-                                        && ( empty( $matches[ $type ] ) || false === array_search( $real, $matches[ $type ], true ) )
+                                        && ( empty( $matches[ $type ] ) || ! in_array( $real, $matches[ $type ], true ) )
                                 ) {
                                         $matches[ $type ][] = $real;

trunk/tests/phpunit/includes/object-cache.php

@@ -2172 +2172 @@
                 }
 
-                if ( false !== array_search( $group, $this->global_groups, true ) ) {
+                if ( in_array( $group, $this->global_groups, true ) ) {
                         $prefix = $this->global_prefix;
                 } else {