Changeset 62701

Timestamp:

07/13/2026 05:16:36 AM (2 months ago)

Author:

ramonopoly

Message:

Block Supports: guard test for element hover styles with a missing hover selector

This commit adds a test to cover the following behaviour: elements (such as buttons) should only render :hover element styles when they define a hover selector.

Props aaronrobertshaw, ramonopoly, westonruter, wildworks.

Follow-up to [65435].

Fixes #65538.

File:

• trunk/tests/phpunit/tests/block-supports/wpRenderElementsSupportStyles.php (modified) (2 diffs)

trunk/tests/phpunit/tests/block-supports/wpRenderElementsSupportStyles.php

@@ -23 +23 @@
          * @ticket 59555
          * @ticket 60557
+         * @ticket 65538
          *
          * @covers ::wp_render_elements_support_styles
@@ -186 +187 @@
                                 'expected_styles' => '/^.wp-elements-\d+ .wp-element-button, .wp-elements-\d+ .wp-block-button__link' . $color_css_rules . '$/',
                         ),
+                        'button hover styles are skipped without a hover selector' => array(
+                                'color_settings'  => array( 'button' => true ),
+                                'elements_styles' => array(
+                                        'button' => array(
+                                                'color'  => $color_styles,
+                                                ':hover' => array( 'color' => $color_styles ),
+                                        ),
+                                ),
+
+                                /*
+                                 * Only the base button rule should be emitted. The button element
+                                 * type has no `hover_selector`, so the `:hover` object must be
+                                 * ignored rather than triggering an undefined array key warning.
+                                 */
+                                'expected_styles' => '/^.wp-elements-\d+ .wp-element-button, .wp-elements-\d+ .wp-block-button__link' . $color_css_rules . '$/',
+                        ),
                         'link element styles are applied'            => array(
                                 'color_settings'  => array( 'link' => true ),