Changeset 62761 for trunk/tests/phpunit/tests/taxonomy.php

Timestamp:

07/15/2026 08:00:44 PM (3 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use more specific assertions instead of assertTrue()/assertFalse().

Replace boolean assertions wrapping other checks with the dedicated PHPUnit assertions:

• assertContains()/assertNotContains() instead of in_array() or array_search() wrapped in assertTrue()/assertFalse().
• assertDirectoryExists() instead of assertTrue( is_dir( ... ) ). This clarifies intent and produces more descriptive failure messages.

Props Soean, mukesh27, SergeyBiryukov.
See #64894.

File:

• trunk/tests/phpunit/tests/taxonomy.php (modified) (1 diff)

trunk/tests/phpunit/tests/taxonomy.php

@@ -896 +896 @@
                 $this->assertIsInt( array_search( 'bar', $wp->public_query_vars, true ) );
                 $this->assertTrue( unregister_taxonomy( 'foo' ) );
-                $this->assertFalse( array_search( 'bar', $wp->public_query_vars, true ) );
+                $this->assertNotContains( 'bar', $wp->public_query_vars );
         }