Changeset 62771

Timestamp:

07/17/2026 04:19:35 PM (3 weeks ago)

Author:

desrosj

Message:

Query: Force author__not_in values to be integers

Props peterwilsoncc, westonruter, xknown, joehoyle, sergeybiryukov, jorbin, johnbillion, desrosj.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-query.php

@@ -2408 +2408 @@
 
                 if ( ! empty( $query_vars['author__not_in'] ) ) {
-                        if ( is_array( $query_vars['author__not_in'] ) ) {
-                                $query_vars['author__not_in'] = array_unique( array_map( 'absint', $query_vars['author__not_in'] ) );
-                                sort( $query_vars['author__not_in'] );
-                        }
-                        $author__not_in = implode( ',', (array) $query_vars['author__not_in'] );
-                        $where         .= " AND {$wpdb->posts}.post_author NOT IN ($author__not_in) ";
+                        $author__not_in_id_list = wp_parse_id_list( $query_vars['author__not_in'] );
+                        if ( count( $author__not_in_id_list ) > 0 ) {
+                                sort( $author__not_in_id_list );
+                                $where .= sprintf(
+                                        " AND {$wpdb->posts}.post_author NOT IN (%s) ",
+                                        implode( ',', $author__not_in_id_list )
+                                );
+                                /** Update the query var for stable cache key generation in {@see self::generate_cache_key()}. */
+                                $query_vars['author__not_in'] = $author__not_in_id_list;
+                        }
                 } elseif ( ! empty( $query_vars['author__in'] ) ) {
                         if ( is_array( $query_vars['author__in'] ) ) {