Changeset 62844

Timestamp:

07/24/2026 03:47:25 PM (44 hours ago)

Author:

joedolson

Message:

Privacy: More accurate admin notices when saving.

When saving Privacy Policy page settings, show a notice that indicates there is no Privacy Policy page set instead of "Privacy Policy page updated successfully" if no page is selected. Differentiate between removing the current page and saving settings with no changes.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/12247

Props anveshika, audrasjb, masteradhoc, micahele, adrianduffell, pedrofigueroa1989, joedolson.
Fixes #59276.

File:

• trunk/src/wp-admin/options-privacy.php (modified) (2 diffs)

trunk/src/wp-admin/options-privacy.php

@@ -52 +52 @@
 
         if ( 'set-privacy-page' === $action ) {
-                $privacy_policy_page_id = isset( $_POST['page_for_privacy_policy'] ) ? (int) $_POST['page_for_privacy_policy'] : 0;
+                $previous_privacy_policy_page_id = (int) get_option( 'wp_page_for_privacy_policy' );
+                $privacy_policy_page_id          = isset( $_POST['page_for_privacy_policy'] ) ? (int) $_POST['page_for_privacy_policy'] : 0;
                 update_option( 'wp_page_for_privacy_policy', $privacy_policy_page_id );
 
-                $privacy_page_updated_message = __( 'Privacy Policy page updated successfully.' );
+                $privacy_page_message_type = 'success';
 
                 if ( $privacy_policy_page_id ) {
+                        $privacy_page_updated_message = __( 'Privacy Policy page updated successfully.' );
+
                         /*
                          * Don't always link to the menu customizer:
@@ -76 +79 @@
                                 );
                         }
-                }
-
-                add_settings_error( 'page_for_privacy_policy', 'page_for_privacy_policy', $privacy_page_updated_message, 'success' );
+                } elseif ( $previous_privacy_policy_page_id ) {
+                        // A previously set Privacy Policy page was cleared.
+                        $privacy_page_updated_message = __( 'Privacy Policy page removed.' );
+                } else {
+                        // No Privacy Policy page was set before, and none is set now.
+                        $privacy_page_updated_message = __( 'No Privacy Policy page is currently set.' );
+                        $privacy_page_message_type    = 'info';
+                }
+
+                add_settings_error( 'page_for_privacy_policy', 'page_for_privacy_policy', $privacy_page_updated_message, $privacy_page_message_type );
         } elseif ( 'create-privacy-page' === $action ) {