Changeset 6285 for trunk/wp-includes/taxonomy.php

Timestamp:

10/23/2007 04:43:15 PM (17 years ago)

Author:

ryan

Message:

Remove unnecessary GROUP BY when getting max term_group. Props michelwp. fixes #5240

File:

• trunk/wp-includes/taxonomy.php (modified) (2 diffs)

trunk/wp-includes/taxonomy.php

@@ -1046 +1046 @@
         } else {
             // The alias isn't in a group, so let's create a new one and firstly add the alias term to it.
-            $term_group = $wpdb->get_var("SELECT MAX(term_group) FROM $wpdb->terms GROUP BY term_group") + 1;
+            $term_group = $wpdb->get_var("SELECT MAX(term_group) FROM $wpdb->terms") + 1;
             $wpdb->query( $wpdb->prepare( "UPDATE $wpdb->terms SET term_group = %d WHERE term_id = %d", $term_group, $alias->term_id ) );
         }
@@ -1256 +1256 @@
         } else {
             // The alias isn't in a group, so let's create a new one and firstly add the alias term to it.
-            $term_group = $wpdb->get_var("SELECT MAX(term_group) FROM $wpdb->terms GROUP BY term_group") + 1;
+            $term_group = $wpdb->get_var("SELECT MAX(term_group) FROM $wpdb->terms") + 1;
             $wpdb->update( $wpdb->terms, compact('term_group'), array( 'term_id' => $alias->term_id ) );
         }