Changeset 62925

Timestamp:

07/29/2026 06:38:25 PM (6 weeks ago)

Author:

westonruter

Message:

Taxonomy: Pass the missing $args to several term hooks.

The edit_terms, edited_terms, edit_term_taxonomy, edited_term_taxonomy, and term_id_filter hooks have documented an $args parameter since 6.1.0, when r53627 added it. However, this new parameter was not passed to all instances of the hooks being fired, resulting in a possible fatal error if a callback is expecting it.

In wp_insert_term() and wp_update_term() the function's own $args is passed. In _update_post_term_count() and _update_generic_term_count() there is no such array, since the actions fire while recounting rather than while a term is being edited, so an empty array is passed.

These call sites were surfaced by the PHPStan extensions under development for this ticket, which are committed separately.

Developed as subset of ​https://github.com/WordPress/wordpress-develop/pull/12022.
Follow-up to r31525, r53627.

See #65376, #55441.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (4 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -2633 +2633 @@
 
                 /** This action is documented in wp-includes/taxonomy.php */
-                do_action( 'edit_terms', $term_id, $taxonomy );
+                do_action( 'edit_terms', $term_id, $taxonomy, $args );
                 $wpdb->update( $wpdb->terms, compact( 'slug' ), compact( 'term_id' ) );
 
                 /** This action is documented in wp-includes/taxonomy.php */
-                do_action( 'edited_terms', $term_id, $taxonomy );
+                do_action( 'edited_terms', $term_id, $taxonomy, $args );
         }
 
@@ -3495 +3495 @@
 
         /** This filter is documented in wp-includes/taxonomy.php */
-        $term_id = apply_filters( 'term_id_filter', $term_id, $tt_id );
+        $term_id = apply_filters( 'term_id_filter', $term_id, $tt_id, $args );
 
         clean_term_cache( $term_id, $taxonomy );
@@ -4250 +4250 @@
 
                 /** This action is documented in wp-includes/taxonomy.php */
-                do_action( 'edit_term_taxonomy', $tt_id, $taxonomy->name );
+                do_action( 'edit_term_taxonomy', $tt_id, $taxonomy->name, array() );
                 $wpdb->update( $wpdb->term_taxonomy, compact( 'count' ), array( 'term_taxonomy_id' => $tt_id ) );
 
                 /** This action is documented in wp-includes/taxonomy.php */
-                do_action( 'edited_term_taxonomy', $tt_id, $taxonomy->name );
+                do_action( 'edited_term_taxonomy', $tt_id, $taxonomy->name, array() );
         }
 }
@@ -4280 +4280 @@
 
                 /** This action is documented in wp-includes/taxonomy.php */
-                do_action( 'edit_term_taxonomy', $term, $taxonomy->name );
+                do_action( 'edit_term_taxonomy', $term, $taxonomy->name, array() );
                 $wpdb->update( $wpdb->term_taxonomy, compact( 'count' ), array( 'term_taxonomy_id' => $term ) );
 
                 /** This action is documented in wp-includes/taxonomy.php */
-                do_action( 'edited_term_taxonomy', $term, $taxonomy->name );
+                do_action( 'edited_term_taxonomy', $term, $taxonomy->name, array() );
         }
 }