Changeset 62956

Timestamp:

07/31/2026 01:08:01 PM (7 weeks ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use array_last() to get the last array element.

This commit replaces $array[ count( $array ) - 1 ] constructs with the array_last() function (added in PHP 8.5 and polyfilled as of WordPress 6.9) for improved readability.

Follow-up to [60672].

Props Soean, westonruter.
See #64897.

Location:

trunk/src

Files:

• wp-admin/includes/ajax-actions.php (modified) (1 diff)
• wp-includes/class-wp-block-parser.php (modified) (1 diff)
• wp-includes/class-wp-query.php (modified) (1 diff)
• wp-includes/class-wp-theme-json.php (modified) (2 diffs)
• wp-includes/pomo/plural-forms.php (modified) (2 diffs)
• wp-trackback.php (modified) (1 diff)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -129 +129 @@
         if ( str_contains( $search, ',' ) ) {
                 $search = explode( ',', $search );
-                $search = $search[ count( $search ) - 1 ];
+                $search = array_last( $search );
         }
 

trunk/src/wp-includes/class-wp-block-parser.php

@@ -343 +343 @@
          */
         public function add_inner_block( WP_Block_Parser_Block $block, $token_start, $token_length, $last_offset = null ) {
-                $parent                       = $this->stack[ count( $this->stack ) - 1 ];
+                $parent                       = $this->stack[ array_key_last( $this->stack ) ];
                 $parent->block->innerBlocks[] = (array) $block;
                 $html                         = substr( $this->document, $parent->prev_offset, $token_start - $parent->prev_offset );

trunk/src/wp-includes/class-wp-query.php

@@ -2431 +2431 @@
                 if ( '' !== $query_vars['author_name'] ) {
                         if ( str_contains( $query_vars['author_name'], '/' ) ) {
-                                $query_vars['author_name'] = explode( '/', $query_vars['author_name'] );
-                                if ( $query_vars['author_name'][ count( $query_vars['author_name'] ) - 1 ] ) {
-                                        $query_vars['author_name'] = $query_vars['author_name'][ count( $query_vars['author_name'] ) - 1 ]; // No trailing slash.
+                                $author_name_parts = explode( '/', $query_vars['author_name'] );
+                                $last_part         = array_last( $author_name_parts );
+
+                                if ( $last_part ) {
+                                        $query_vars['author_name'] = $last_part; // No trailing slash.
                                 } else {
-                                        $query_vars['author_name'] = $query_vars['author_name'][ count( $query_vars['author_name'] ) - 2 ]; // There was a trailing slash.
+                                        $query_vars['author_name'] = $author_name_parts[ count( $author_name_parts ) - 2 ]; // There was a trailing slash.
                                 }
                         }

trunk/src/wp-includes/class-wp-theme-json.php

@@ -3995 +3995 @@
                 $is_processing_element = in_array( 'elements', $block_metadata['path'], true );
 
-                $current_element = $is_processing_element ? $block_metadata['path'][ count( $block_metadata['path'] ) - 1 ] : null;
+                $current_element = $is_processing_element ? array_last( $block_metadata['path'] ) : null;
 
                 $element_pseudo_allowed = array();
@@ -4689 +4689 @@
                          * $metadata['path'] = array( 'styles', 'elements', 'link' );
                          */
-                        $current_element = $metadata['path'][ count( $metadata['path'] ) - 1 ];
+                        $current_element = array_last( $metadata['path'] );
 
                         /*

trunk/src/wp-includes/pomo/plural-forms.php

@@ -129 +129 @@
                                                 $found = false;
                                                 while ( ! empty( $stack ) ) {
-                                                        $o2 = $stack[ count( $stack ) - 1 ];
+                                                        $o2 = array_last( $stack );
                                                         if ( '(' !== $o2 ) {
                                                                 $output[] = array( 'op', array_pop( $stack ) );
@@ -164 +164 @@
 
                                                 while ( ! empty( $stack ) ) {
-                                                        $o2 = $stack[ count( $stack ) - 1 ];
+                                                        $o2 = array_last( $stack );
 
                                                         // Ternary is right-associative in C.

trunk/src/wp-trackback.php

@@ -51 +51 @@
 if ( ! isset( $_GET['tb_id'] ) || ! $_GET['tb_id'] ) {
         $post_id = explode( '/', $_SERVER['REQUEST_URI'] );
-        $post_id = (int) $post_id[ count( $post_id ) - 1 ];
+        $post_id = (int) array_last( $post_id );
 }